Closed
Bug 773965
Opened 12 years ago
Closed 12 years ago
Ignore *.pyc and *.DS_Store files that we do not want
Categories
(Add-on SDK Graveyard :: General, defect, P3)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.11
People
(Reporter: evold, Assigned: evold)
Details
Attachments
(2 files)
I don't see why we require new contributors to globally ignore *.pyc files and other files that we clearly do not want in our repo, I have three reasons: 1. contributors may actually want *.pyc files in other repos 2. It puts a ugly roadblock in the way of new contributors that may not grok git, and make contributing more painful. 3. When reformat my computers or get a new one, I have to add these ignores to my global ignore, and it's just an annoying step to have to do; I don't see the reason for it. In bug 597125 Atul said he didn't want to do this, but never gave a good reason for it, zpao agreed that it was a bad idea, but Atul never changed his mind..
Assignee: nobody → evold
Priority: -- → P3
Assignee | ||
Comment 1•12 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Comment 2•12 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Updated•12 years ago
|
Attachment #653987 -
Flags: review?(poirot.alex)
Updated•12 years ago
|
Attachment #653987 -
Flags: review?(poirot.alex) → review+
Comment 3•12 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/d9bef8b14099e9d6f48564011b20be716c27b6a0 Merge pull request #530 from erikvold/773965 Bug 773965 explicitly ignoring unwanted files r=@ochameau
Updated•12 years ago
|
Target Milestone: --- → 1.11
Updated•12 years ago
|
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Comment 4•12 years ago
|
||
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/d9bef8b14099e9d6f48564011b20be716c27b6a0 Merge pull request #530 from erikvold/773965
Comment 5•12 years ago
|
||
Commit pushed to release at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/d9bef8b14099e9d6f48564011b20be716c27b6a0 Merge pull request #530 from erikvold/773965
You need to log in
before you can comment on or make changes to this bug.
Description
•