Ignore *.pyc and *.DS_Store files that we do not want

RESOLVED FIXED in 1.11

Status

P3
normal
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: evold, Assigned: evold)

Tracking

unspecified
1.11

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

I don't see why we require new contributors to globally ignore *.pyc files and other files that we clearly do not want in our repo, I have three reasons:

1. contributors may actually want *.pyc files in other repos
2. It puts a ugly roadblock in the way of new contributors that may not grok git, and make contributing more painful.
3. When reformat my computers or get a new one, I have to add these ignores to my global ignore, and it's just an annoying step to have to do; I don't see the reason for it.

In bug 597125 Atul said he didn't want to do this, but never gave a good reason for it, zpao agreed that it was a bad idea, but Atul never changed his mind..

Updated

6 years ago
Assignee: nobody → evold

Updated

6 years ago
Priority: -- → P3
Created attachment 653986 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/530

Pointer to Github pull-request
Created attachment 653987 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/530#

Pointer to Github pull-request
Attachment #653987 - Flags: review?(poirot.alex)
Attachment #653987 - Flags: review?(poirot.alex) → review+

Comment 3

6 years ago
Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/d9bef8b14099e9d6f48564011b20be716c27b6a0
Merge pull request #530 from erikvold/773965

Bug 773965 explicitly ignoring unwanted files r=@ochameau
Target Milestone: --- → 1.11
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED

Comment 4

6 years ago
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/d9bef8b14099e9d6f48564011b20be716c27b6a0
Merge pull request #530 from erikvold/773965
You need to log in before you can comment on or make changes to this bug.