Last Comment Bug 774018 - Remove extra ;
: Remove extra ;
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: XPCOM (show other bugs)
: unspecified
: x86_64 Linux
: -- normal (vote)
: mozilla16
Assigned To: Nobody; OK to take it and work on it
:
Mentors:
Depends on:
Blocks: clang
  Show dependency treegraph
 
Reported: 2012-07-14 19:30 PDT by Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
Modified: 2012-07-15 17:52 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
remove extra ; (390 bytes, patch)
2012-07-14 19:30 PDT, Rafael Ávila de Espíndola (:espindola) (not reading bugmail)
khuey: review+
Details | Diff | Review

Description Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2012-07-14 19:30:53 PDT
Created attachment 642311 [details] [diff] [review]
remove extra ;
Comment 1 Kyle Huey [:khuey] (khuey@mozilla.com) (Away until 6/13) 2012-07-14 19:52:48 PDT
Comment on attachment 642311 [details] [diff] [review]
remove extra ;

Review of attachment 642311 [details] [diff] [review]:
-----------------------------------------------------------------

FWIW, this sort of stuff doesn't really need review.
Comment 2 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2012-07-14 21:08:41 PDT
> FWIW, this sort of stuff doesn't really need review.

That is awesome! Where is it documented?
Comment 3 Kyle Huey [:khuey] (khuey@mozilla.com) (Away until 6/13) 2012-07-14 21:11:37 PDT
I don't know if we've written it down anywhere, but it's a pretty well-understood norm that absolutely trivial changes made by people who know what they're doing don't need review.
Comment 4 Rafael Ávila de Espíndola (:espindola) (not reading bugmail) 2012-07-14 21:22:20 PDT
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #3)
> I don't know if we've written it down anywhere, but it's a pretty
> well-understood norm that absolutely trivial changes made by people who know
> what they're doing don't need review.

Finding out what is "absolutely trivial" is what I have problems with. I have had to wait days for a missing include in the past for example.
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-07-15 10:20:15 PDT
https://hg.mozilla.org/mozilla-central/rev/7712c66a20fc
Comment 6 :Ehsan Akhgari (busy, don't ask for review please) 2012-07-15 17:52:40 PDT
(In reply to comment #4)
> (In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #3)
> > I don't know if we've written it down anywhere, but it's a pretty
> > well-understood norm that absolutely trivial changes made by people who know
> > what they're doing don't need review.
> 
> Finding out what is "absolutely trivial" is what I have problems with. I have
> had to wait days for a missing include in the past for example.

My rule of thumb is to ask myself will someone be able to object to this patch not getting reviewed without implicitly questioning their own sanity?  Fixing double semi-colons is the sort of thing which I would fix without asking for review (and indeed I've already done that a bunch of times).

Note You need to log in before you can comment on or make changes to this bug.