Closed Bug 774018 Opened 12 years ago Closed 12 years ago

Remove extra ;

Categories

(Core :: XPCOM, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla16

People

(Reporter: espindola, Unassigned)

References

Details

Attachments

(1 file)

Attached patch remove extra ;Splinter Review
      No description provided.
Attachment #642311 - Attachment is patch: true
Attachment #642311 - Flags: review?(khuey)
Comment on attachment 642311 [details] [diff] [review]
remove extra ;

Review of attachment 642311 [details] [diff] [review]:
-----------------------------------------------------------------

FWIW, this sort of stuff doesn't really need review.
Attachment #642311 - Flags: review?(khuey) → review+
> FWIW, this sort of stuff doesn't really need review.

That is awesome! Where is it documented?
I don't know if we've written it down anywhere, but it's a pretty well-understood norm that absolutely trivial changes made by people who know what they're doing don't need review.
(In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #3)
> I don't know if we've written it down anywhere, but it's a pretty
> well-understood norm that absolutely trivial changes made by people who know
> what they're doing don't need review.

Finding out what is "absolutely trivial" is what I have problems with. I have had to wait days for a missing include in the past for example.
https://hg.mozilla.org/mozilla-central/rev/7712c66a20fc
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla16
(In reply to comment #4)
> (In reply to Kyle Huey [:khuey] (khuey@mozilla.com) from comment #3)
> > I don't know if we've written it down anywhere, but it's a pretty
> > well-understood norm that absolutely trivial changes made by people who know
> > what they're doing don't need review.
> 
> Finding out what is "absolutely trivial" is what I have problems with. I have
> had to wait days for a missing include in the past for example.

My rule of thumb is to ask myself will someone be able to object to this patch not getting reviewed without implicitly questioning their own sanity?  Fixing double semi-colons is the sort of thing which I would fix without asking for review (and indeed I've already done that a bunch of times).
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: