Last Comment Bug 774054 - Switch mochitest file $(INSTALL) to install_cmd
: Switch mochitest file $(INSTALL) to install_cmd
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Build Config (show other bugs)
: Trunk
: x86_64 Windows 7
: -- normal (vote)
: mozilla17
Assigned To: Siddharth Agarwal [:sid0] (inactive)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-15 02:47 PDT by Siddharth Agarwal [:sid0] (inactive)
Modified: 2012-07-20 06:44 PDT (History)
3 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
patch (1.86 KB, patch)
2012-07-15 02:47 PDT, Siddharth Agarwal [:sid0] (inactive)
mh+mozilla: review+
Details | Diff | Review

Description Siddharth Agarwal [:sid0] (inactive) 2012-07-15 02:47:45 PDT
Created attachment 642356 [details] [diff] [review]
patch

Easy win, since with pymake install_cmd is a native command.
Comment 1 Mike Hommey [:glandium] 2012-07-16 06:32:35 PDT
Comment on attachment 642356 [details] [diff] [review]
patch

Review of attachment 642356 [details] [diff] [review]:
-----------------------------------------------------------------

::: config/makefiles/mochitest.mk
@@ +14,5 @@
>  endif
>  
>  define mochitest-libs-rule-template
>  libs:: $$($(1))
> +	$(call install_cmd,$$(foreach f,$$^,"$$(f)") $$(call mochitestdir,$(2)))

r=me with $$(call instead of $(call
Comment 2 Siddharth Agarwal [:sid0] (inactive) 2012-07-19 12:44:03 PDT
http://hg.mozilla.org/integration/mozilla-inbound/rev/e1b7eef10f3e
Comment 3 Ed Morley [:emorley] 2012-07-20 06:44:47 PDT
https://hg.mozilla.org/mozilla-central/rev/e1b7eef10f3e

Note You need to log in before you can comment on or make changes to this bug.