Closed Bug 774063 Opened 12 years ago Closed 12 years ago

Use image instead of html:img in addressbook contacts

Categories

(Thunderbird :: Address Book, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 17.0

People

(Reporter: iannbugzilla, Assigned: iannbugzilla)

References

Details

Attachments

(1 file)

Following landing of Bug 762669 and Bug 773821 for SeaMonkey, might as well port the removal of html:img to Thunderbird.
Attachment #642367 - Flags: review?(mbanner)
Attachment #642367 - Flags: review?(mbanner) → review+
Comment on attachment 642367 [details] [diff] [review]
Remove html:img [Checked in: Comment 5]

Just to make sure I have not missed anything.
Attachment #642367 - Flags: ui-review?(bwinton)
Comment on attachment 642367 [details] [diff] [review]
Remove html:img [Checked in: Comment 5]

Looks good, but it seems like we've added one more…

mail/components/im/content/imbuddytooltip.xml
38:        <html:img anonid="userIcon"/>

Would you mind removing that one, too?

Thanks,
Blake.
Comment on attachment 642367 [details] [diff] [review]
Remove html:img [Checked in: Comment 5]

Looks good, but it seems like we've added one more…

mail/components/im/content/imbuddytooltip.xml
38:        <html:img anonid="userIcon"/>

Would you mind removing that one, too?

(Oh, and ui-r=me.)

Thanks,
Blake.
Attachment #642367 - Flags: ui-review?(bwinton) → ui-review+
Blocks: 778534
(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #3)
> Comment on attachment 642367 [details] [diff] [review]

> Looks good, but it seems like we've added one more…
> 
> mail/components/im/content/imbuddytooltip.xml
> 38:        <html:img anonid="userIcon"/>
> 
> Would you mind removing that one, too?
I've spun that off into bug 778534 as it will need a separate review.
Comment on attachment 642367 [details] [diff] [review]
Remove html:img [Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/32fde46fb889
Attachment #642367 - Attachment description: Remove html:img → Remove html:img [Checked in: Comment 5]
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Flags: in-qa-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: