Last Comment Bug 774063 - Use image instead of html:img in addressbook contacts
: Use image instead of html:img in addressbook contacts
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Address Book (show other bugs)
: Trunk
: All All
: -- normal (vote)
: Thunderbird 17.0
Assigned To: Ian Neal
:
:
Mentors:
Depends on: 762669 773821
Blocks: 778534
  Show dependency treegraph
 
Reported: 2012-07-15 04:43 PDT by Ian Neal
Modified: 2012-07-29 05:18 PDT (History)
2 users (show)
iann_bugzilla: in‑qa‑testsuite-
iann_bugzilla: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---


Attachments
Remove html:img [Checked in: Comment 5] (3.75 KB, patch)
2012-07-15 04:43 PDT, Ian Neal
standard8: review+
bwinton: ui‑review+
Details | Diff | Splinter Review

Description Ian Neal 2012-07-15 04:43:02 PDT
Created attachment 642367 [details] [diff] [review]
Remove html:img [Checked in: Comment 5]

Following landing of Bug 762669 and Bug 773821 for SeaMonkey, might as well port the removal of html:img to Thunderbird.
Comment 1 Ian Neal 2012-07-17 10:05:55 PDT
Comment on attachment 642367 [details] [diff] [review]
Remove html:img [Checked in: Comment 5]

Just to make sure I have not missed anything.
Comment 2 Blake Winton (:bwinton) (:☕️) 2012-07-23 11:11:50 PDT
Comment on attachment 642367 [details] [diff] [review]
Remove html:img [Checked in: Comment 5]

Looks good, but it seems like we've added one more…

mail/components/im/content/imbuddytooltip.xml
38:        <html:img anonid="userIcon"/>

Would you mind removing that one, too?

Thanks,
Blake.
Comment 3 Blake Winton (:bwinton) (:☕️) 2012-07-23 11:12:05 PDT
Comment on attachment 642367 [details] [diff] [review]
Remove html:img [Checked in: Comment 5]

Looks good, but it seems like we've added one more…

mail/components/im/content/imbuddytooltip.xml
38:        <html:img anonid="userIcon"/>

Would you mind removing that one, too?

(Oh, and ui-r=me.)

Thanks,
Blake.
Comment 4 Ian Neal 2012-07-29 05:13:00 PDT
(In reply to Blake Winton (:bwinton - Thunderbird UX) from comment #3)
> Comment on attachment 642367 [details] [diff] [review]

> Looks good, but it seems like we've added one more…
> 
> mail/components/im/content/imbuddytooltip.xml
> 38:        <html:img anonid="userIcon"/>
> 
> Would you mind removing that one, too?
I've spun that off into bug 778534 as it will need a separate review.
Comment 5 Ian Neal 2012-07-29 05:18:19 PDT
Comment on attachment 642367 [details] [diff] [review]
Remove html:img [Checked in: Comment 5]

http://hg.mozilla.org/comm-central/rev/32fde46fb889

Note You need to log in before you can comment on or make changes to this bug.