Closed Bug 774090 Opened 12 years ago Closed 12 years ago

Implement Bug 686959 on IM

Categories

(Thunderbird :: Theme, defect)

Product:
Thunderbird
Component:
Theme
Platform:
All
Windows 7
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(thunderbird16 fixed)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 17.0
Tracking Flags:
Tracking Status
thunderbird16 --- fixed

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(2 files, 1 obsolete file)

comparision with folder sidebar
13.31 KB, image/png
Details
patch v2
4.19 KB, patch
andreasn
: review+
andreasn
: ui-review+
standard8
: approval-comm-aurora+
Details | Diff | Splinter Review 
Bug 686959 enhanced the treechildrens and listitems native appearance. This bug is to implement this for the contactlistbox entries.
Attached patch patch (obsolete) — — Splinter Review 
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED

        Attachment #642394 -
        Flags: ui-review?(nisses.mail)

        Attachment #642394 -
        Flags: review?(nisses.mail)

    
    

    
  
Looks good, apart from a small nitpick with the unselected state where it seems to be lacking a white line at the top. ui-r+ with that fixed.

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch v2
        — 
          — Splinter Review
      

    


  
Yeah, the treechildren are a little bit different than the other elements. Added background-origin: border-box and it should be okay now.

        Attachment #642394 -
        Attachment is obsolete: true

        Attachment #642394 -
        Flags: ui-review?(nisses.mail)

        Attachment #642394 -
        Flags: review?(nisses.mail)

        Attachment #649278 -
        Flags: ui-review?(nisses.mail)

        Attachment #649278 -
        Flags: review?(nisses.mail)

    
    

    
  
Comment on attachment 649278 [details] [diff] [review]
patch v2

excellent!

        Attachment #649278 -
        Flags: ui-review?(nisses.mail) → ui-review+

    
    

    
  
Comment on attachment 649278 [details] [diff] [review]
patch v2

code looks good too!

        Attachment #649278 -
        Flags: review?(nisses.mail) → review+

    
  
Keywords: checkin-needed

    
    

    
  
Comment on attachment 649278 [details] [diff] [review]
patch v2

Bug 686959 has target TB 16. So this be good also for TB 16.

        Attachment #649278 -
        Flags: approval-comm-aurora?

    
    

    
  
https://hg.mozilla.org/comm-central/rev/0fed583977b2
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0

        Attachment #649278 -
        Flags: approval-comm-aurora? → approval-comm-aurora+

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: