The default bug view has changed. See this FAQ.

Implement Bug 686959 on IM

RESOLVED FIXED in Thunderbird 17.0

Status

Thunderbird
Theme
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Paenglab, Assigned: Paenglab)

Tracking

unspecified
Thunderbird 17.0
All
Windows 7
Bug Flags:
in-testsuite -

Thunderbird Tracking Flags

(thunderbird16 fixed)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Bug 686959 enhanced the treechildrens and listitems native appearance. This bug is to implement this for the contactlistbox entries.
(Assignee)

Comment 1

5 years ago
Created attachment 642394 [details] [diff] [review]
patch
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #642394 - Flags: ui-review?(nisses.mail)
Attachment #642394 - Flags: review?(nisses.mail)
Looks good, apart from a small nitpick with the unselected state where it seems to be lacking a white line at the top. ui-r+ with that fixed.
Created attachment 649260 [details]
comparision with folder sidebar
(Assignee)

Comment 4

5 years ago
Created attachment 649278 [details] [diff] [review]
patch v2

Yeah, the treechildren are a little bit different than the other elements. Added background-origin: border-box and it should be okay now.
Attachment #642394 - Attachment is obsolete: true
Attachment #642394 - Flags: ui-review?(nisses.mail)
Attachment #642394 - Flags: review?(nisses.mail)
Attachment #649278 - Flags: ui-review?(nisses.mail)
Attachment #649278 - Flags: review?(nisses.mail)
Comment on attachment 649278 [details] [diff] [review]
patch v2

excellent!
Attachment #649278 - Flags: ui-review?(nisses.mail) → ui-review+
Comment on attachment 649278 [details] [diff] [review]
patch v2

code looks good too!
Attachment #649278 - Flags: review?(nisses.mail) → review+
(Assignee)

Updated

5 years ago
Keywords: checkin-needed
(Assignee)

Comment 7

5 years ago
Comment on attachment 649278 [details] [diff] [review]
patch v2

Bug 686959 has target TB 16. So this be good also for TB 16.
Attachment #649278 - Flags: approval-comm-aurora?
https://hg.mozilla.org/comm-central/rev/0fed583977b2
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Flags: in-testsuite-
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
Attachment #649278 - Flags: approval-comm-aurora? → approval-comm-aurora+
https://hg.mozilla.org/releases/comm-aurora/rev/db0e36fc782f
status-thunderbird16: --- → fixed
You need to log in before you can comment on or make changes to this bug.