Closed
Bug 774175
Opened 13 years ago
Closed 13 years ago
Support X-Conditions-Accepted in SyncServer live functional tests
Categories
(Cloud Services Graveyard :: Server: Sync, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: rfkelly, Unassigned)
Details
(Whiteboard: [qa+])
Attachments
(1 file)
|
492 bytes,
patch
|
alexis+bugs
:
review+
|
Details | Diff | Splinter Review |
The latest tokenserver API includes an X-Conditions-Accepted header which may need to be passed in before getting a valid token. This patch changes the live functional tests to pass in this header unconditionally when calling the tokenserver.
I assume this to be safe and the tokenserver will ignore it if it's not needed. Alexis r? in case this assumption is incorrect.
Attachment #642479 -
Flags: review?(alexis)
|
||
Comment 1•13 years ago
|
||
This assumption is correct. Normally you only have to pass this option if the user didn't already accepted the conditions, but you can pass it everytime if you want as well, it will not hurt.
We're also adding a feature to have this deactivable per service, still discussing if it will be in the configuration or in the database tho.
|
|
||
Updated•13 years ago
|
Attachment #642479 -
Flags: review?(alexis) → review+
|
||
Updated•13 years ago
|
Whiteboard: [qa+]
|
Reporter | |
Comment 2•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
||
Updated•2 years ago
|
Product: Cloud Services → Cloud Services Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•