774184 - Another document with this slug already exists

Status: RESOLVED FIXED

(developer.mozilla.org Graveyard :: Editing, defect, P2)

Description

[Jean-Yves Perrier [:teoli]]

When trying to update https://developer-new.mozilla.org/en-US/docs/CSS/Getting_Started/JavaScript

I get the error message +Another document with this slug already exists+.

But I didn't touch the slug, and the document already exists (so I can't fix the template error on it.

Comment 1

[Jean-Yves Perrier [:teoli]]

Same here: https://developer-new.mozilla.org/en-US/docs/SVG/Tutorial/Introduction (I list them here so that I don't forget about them)

Comment 2

[John Karahalis [:openjck]]

Interesting. It looks like the slug does not take the full path into consideration -- docs/CSS/Getting_Started/JavaScript is treated the same as /docs/JavaScript.

In both of these cases, there is an article with the same name but at a different path.

https://developer-new.mozilla.org/en-US/docs/JavaScript
https://developer-new.mozilla.org/en-US/docs/Introduction

Comment 3

[Eric Shepherd [:sheppy]]

Yeah, this is happening to me in a couple of places too.

Comment 5

[John Karahalis [:openjck]]

Here's another:

https://developer-new.mozilla.org/en-US/docs/CSS/length

gives an error, possibly because of...

https://developer-new.mozilla.org/en-US/docs/length

Comment 6

[John Karahalis [:openjck]]

Ali: This bug is not related to reading, but it is one of the more significant editor-facing bugs. Thoughts on blocker status?

Comment 7

[John Karahalis [:openjck]]

Louis-Remi just ran into this in bug 776018. It's affecting a large percentage of the docs team, so it will probably affect a large percentage of our users as well.

Comment 8

[Eric Shepherd [:sheppy]]

Yeah, this is happening on several articles. I have yet to see a pattern.

Comment 9

[John Karahalis [:openjck]]

Sheppy: As far as I can tell, the pattern is this: You cannot save any page that has the same slug as another document.

For example, these two articles have different paths but the same slug. This causes an error.

https://developer-new.mozilla.org/en-US/docs/CSS/length
https://developer-new.mozilla.org/en-US/docs/length

Comment 10

[Eric Shepherd [:sheppy]]

Hm. I was under the impression that the slug is supposed to be the full path of the page other than the part prior to "docs". So the first of those would be "CSS/length" and the second "length". If that's not the case, that's a bug of pretty epic proportions, since we've known all along (and made it quite clear in multiple meetings) that pages with the same name and slug were going to be common due to the same names being used in multiple APIs.

Comment 11

[David Walsh :davidwalsh]

I think I know what the issue could be here, and it's to do with the secondary form validation I created, the one that ensured that no slash was present in slug returned by the form.  

The last piece of the slug gets removed, then validated, so "CSS/length" becomes just "length" which colides with "/length" which is already present.

Sheppy:  This isn't a requirements issue, it's a "there's so much that could happen with slugs that something popped up" issue;  it all relates to only accepting the last piece of the slug heirarchy in the form.  

I'll look to fix during the conference tomorrow.  I'm too exhausted from 3 weeks without a day off to try to fix it tonight.

Comment 12

[David Walsh :davidwalsh]

OK, I've confirmed the root issue, have a solution working locally, will have hopefully by end of day.

Comment 14

[[github robot]]

Commits pushed to master at https://github.com/mozilla/kuma

https://github.com/mozilla/kuma/commit/c176e2ac567f05f4ab53e4ea9221f4c951547c03
fix bug 774184 - prevent duplicate slug error message

https://github.com/mozilla/kuma/commit/90fa492c75fc096876718b46e4b3b202a1f80262
Merge pull request #435 from darkwing/slug-taken-774184

fix bug 774184 - prevent duplicate slug error message

Comment 15

[Jean-Yves Perrier [:teoli]]

That's not yet on developer-new. How are the push to it scheduled for the moment (once a day, each couple of days, once a week)? (So that I know when to verify old bugs I reported/experienced on it).

Comment 16

[Luke Crouch [:groovecoder]]

Right now we push "as-needed" We plan to push today.

We should decide how often we would like to push.

FWIW, Raymond marks bugs as Verified:Fixed when he verifies them on -new.

Comment 17

[Jean-Yves Perrier [:teoli]]

Cool thanks.