774230 - SeaMonkey version detected incorrectly on SeaMonkey addon pages

Status: RESOLVED DUPLICATE of bug 1150912

(addons.mozilla.org Graveyard :: Public Pages, defect)

Description

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; Linux x86_64; rv:16.0) Gecko/16.0 Firefox/16.0 SeaMonkey/2.13a1 ID:20120715003006 CSet: a52505700b63

I just went to https://addons.mozilla.org/en-US/seamonkey/addon/am-context/?src=cb-dl-updated to see why this addon says "Not available for SeaMonkey 2.13a1". Now in the bottom "Versions" foldout it says that this addon is available for "SeaMonkey 2.1 and later". So I try to install it anyway. I get a warning telling me that "I need Firefox 10.0 or later". Now WTF? An add-on "for SeaMonkey 2.1 and later" cannot be installed on SeaMonkey 2.13a1 because "I need Firefox 10.0 or later"? I don't understand.

Comment 1

[Rob Hudson [:robhudson]]

See also bug 666303

Comment 2

[Tony Mechelynck [:tonymec]]

P.S. Another recently updated addon, "Highlighted Text to File" https://addons.mozilla.org/en-US/seamonkey/addon/highlighted-text-to-file/?src=cb-dl-updated which supports "SeaMonkey 2.0 and later", is correctly detected as compatible with SeaMonkey 2.13a1. I haven't installed it, and I haven't compared its install.rdf with that of "Add-on Manager Context Menu" (am-context, see comment  #0) to look for any obvious difference. The latter addon could be installed successfully; its "enhanced" context menu appeared at the next restart (I didn't try closing and reopening the addon manager window). FWIW though, I have extensions.checkCompatibility.nightly set to false in about:config.

Comment 3

[Phoenix]

(In reply to Rob Hudson [:robhudson] from comment #1)
> See also bug 666303
Wow, just 3 month after I post the fix, but it's still unpushed, looks like amo people are *very* busy to make one line change...

Comment 4

[Tony Mechelynck [:tonymec]]

(In reply to Phoenix from comment #3)
> (In reply to Rob Hudson [:robhudson] from comment #1)
> > See also bug 666303
> Wow, just 3 month after I post the fix, but it's still unpushed, looks like
> amo people are *very* busy to make one line change...

Maybe you should have attached a patch in that other bug, asked for r?, and at r+ set checkin-needed? A mere comment is easily overlooked.

Comment 5

[Phoenix]

They use git, I have no knowledge how to use it and create patches there

Comment 6

[David E. Ross]

Would disabling "Advertise Firefox compatibility" be a work-around?

Comment 7

[Tony Mechelynck [:tonymec]]

(In reply to David E. Ross from comment #6)
> Would disabling "Advertise Firefox compatibility" be a work-around?

No it doesn't. My usual user-agent is:

Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/19.0 Firefox/19.0 SeaMonkey/2.16a1

(the default) and with it, I see the bug.

With this user-agent (unchecking "Edit → Preferences → Advanced → HTTP Networking → User Agent String → Advertise Firefox compatibility", or toggling general.useragent.compatMode.firefox to false in about:config):

Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/19.0 SeaMonkey/2.16a1

there is no change, all symptoms are identical.

Comment 8

[Tony Mechelynck [:tonymec]]

P.S. In particular, in the circumstances of comment #0, the *SeaMonkey* AMO page still says (on the page) that the extension isn't compatible with SeaMonkey 2.16a1 and (on the popup when I click to install) that I need "Firefox 10.0 or later" (sic).

This is an extension which would benefit from "Default to Compatible" and therefore shouldn't need to explicitly set its maxVersion to 2.16a1 or higher on the server. (The foldout at the bottom of the extension page mentions a minimum version followed by "or later" but no maximum version.)

Comment 9

[Rob Hudson [:robhudson]]

Fixed. See comments in https://bugzilla.mozilla.org/show_bug.cgi?id=666303#c15.

Comment 10

[Tony Mechelynck [:tonymec]]

Mozilla/5.0 (X11; Linux x86_64; rv:19.0) Gecko/19.0 Firefox/19.0 SeaMonkey/2.16a1 ID:20121019003003 c-c:bd22a204044b m-c:0ff60bfb3442

The bug may be "fixed" at allizom.org but AFAICT it has not yet percolated to the production site addons.mozilla.org (there, the popup still tells me that I need "Firefox 10.0 or later"). How often are new fixes ported to production?

Comment 11

[Rob Hudson [:robhudson]]

It should have gone out with our Thursday push, but I don't see it in the javascript. We have had some trouble with stale static content on our CDN lately so it could be that. I'll report and check on Monday.

Comment 12

[Tony Mechelynck [:tonymec]]

This "fix" has obviously not taken hold: see bug 1150912