774254 - GroupedRating statistics not working

Status: VERIFIED FIXED

(Marketplace Graveyard :: Consumer Pages, defect)

Description

[Victor Carciu]

Prerequisites:
Mozilla/5.0 (Windows NT 6.1; WOW64; rv:16.0) Gecko/16.0 Firefox/16.0

Steps to reproduce:
1.Go to MP and open one app with reviews added.
2.Open reviews section in order to see all reviews
3.Under app title, click the <<number of reviews>> link

Expected results:
Reviews statistics dropdown menu is displayed(number of ratings based on given stars)

Actual results:
For some apps this action is not working

Please see screencast for this bug: http://screencast.com/t/eaN9ivgENVYA

NOTE:
This issue is NOT reproducible for all apps. I observed that if we have an app where the issue is reproducible, if we add a review then everything will work as expected, but we should be able to see this section even if there are reviews only from another users.

Comment 1

[Matt Basta [:basta]]

Victor: Can you post some examples of apps that do and don't exhibit this problem?

Comment 2

[Christopher Van Wiemeersch [:cvan]]

Regression from https://github.com/mozilla/zamboni/commit/f0813d5

Comment 3

[Victor Carciu]

Matt :
I investigated this issue and I observed that the issue is reproducible for ALL apps if no new review is added. After adding a review, GroupedRating works as expected.

Comment 4

[Matt Basta [:basta]]

Fixed by Good Guy Wraithan:

https://github.com/mozilla/zamboni/commit/3af2dabbcc3a51b986b5c10896e7c460d4ab9879
https://github.com/mozilla/zamboni/commit/f67a5ea0c228de2de9f0b3364285d78a40d782a8

Comment 5

[Victor Carciu]

Verified as fixed : http://screencast.com/t/m18WCaZ9ebE2

Comment 6

[Victor Carciu]

Reproducible again as described in comment #3.

Comment 7

[Matt Basta [:basta]]

Should be fixed again:

https://github.com/mozilla/zamboni/commit/46a5eed9dcb6252457b08db6ea793f9c8b2dc93d

Comment 8

[Victor Carciu]

Verified as fixed.