Closed Bug 77427 Opened 23 years ago Closed 23 years ago

advanced edit for table properties doesn't work <table>

Categories

(Core :: DOM: Editor, defect, P2)

Product:
Core
Component:
DOM: Editor
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
mozilla0.9.2

People

(Reporter: Brade, Assigned: cmanske)

Details

(Whiteboard: [dialog]advanced edit)

Attachments

(2 files)

Fix.
1.99 KB, patch
Details | Diff | Splinter Review
Fix for problem in EdInsertTable.js (forgot to include before)
876 bytes, patch
Details | Diff | Splinter Review 
The advanced edit dialog doesn't seem to work for table properties.

 * new composer page
 * insert table (2x2 is fine)
 * go back to properties
 * switch to table tab
 * click advanced edit button
 * add some properties (like id=mytable and foo=bar)
 * click OK to advanced edit button
 * click advanced edit button to see that the properties are still listed there
 * dismiss advanced edit dialog
 * click OK to table dialog
 * go to html source or back to advanced edit dialog for <table>
Notice that the attributes were never added.
I'm in the middle of a major revision for this dialog, so I can't even test
this bug. It will be fixed "automatically" when bug 71743 is fixed.
Status: NEW → ASSIGNED
Depends on: 71743
Target Milestone: --- → mozilla0.9.1
Adding keyword to track Advanced Edit dialog bugs that will be fixed with
bug 71743
Whiteboard: advanced edit
Moving dependent Advance Edit Dialog bugs to 0.9.2
Target Milestone: mozilla0.9.1 → mozilla0.9.2
Keywords: correctness
Priority: -- → P2
Whiteboard: advanced edit → [dialog]advanced edit
remove dependency on bug #71743
the fix there really has nothing to do with this bug (and doesn't fix it).

I think this bug is particular bad because we can change an existing id in the 
dialog but it doesn't get recorded in the dom.
No longer depends on: 71743
I disagree. This works fine in my build!
I added both "id" and "foo", and they show up in
HTML source after inserting a table.
I doesn't matter if we leave off the dependency, we will have to verify it
separately anyway.


note: remember to get to the advanced edit dialog from the *table* tab (not the 
cell tab)
Summary: advanced edit for table properties doesn't work → advanced edit for table properties doesn't work <table>
Attached patch Fix. — — Splinter Review 

    
    

    
  
Patch fixes the problem after using Advanced Edit. Also fixes an error in the
table align code that prevented "right" align from working, as well as removing a
method that doesn't exist (SetSpanEnabled).


Keywords: patch, 
          
            review
Whiteboard: [dialog]advanced edit → [dialog]advanced edit FIX IN HAND need r=, sr=

    
    

    
  
sr=kin
Whiteboard: [dialog]advanced edit FIX IN HAND need r=, sr= → [dialog]advanced edit FIX IN HAND need r=

    
    

    
  
r=sfraser
Whiteboard: [dialog]advanced edit FIX IN HAND need r= → [dialog]advanced edit

    
  
Whiteboard: [dialog]advanced edit → [dialog]advanced edit, fix in hand, need a=

    
  
Blocks: 83989

    
    

    
  
a= asa@mozilla.org for checkin to the trunk.
(on behalf of drivers)

    
    

    
  
checked in.

No longer blocks: 83989
Status: ASSIGNED → RESOLVED
Closed: 23 years ago
Keywords: patch, 
          
            review
Resolution: --- → FIXED
Whiteboard: [dialog]advanced edit, fix in hand, need a= → [dialog]advanced edit

    
    

    
  
verified in 6/25 build.
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: