774301 - Many "selections(window) is null" during tests

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect, P1)

Description

[Alexandre Poirot [:ochameau]]

We are currently seing many of this following exception:
error: An exception occurred.
Traceback (most recent call last):
  File "resource://ef7cc3af-6f6e-4472-b8d0-765d73f121e7-at-jetpack/api-utils/lib/system/events.js", line 58, in 
    data: data
  File "resource://ef7cc3af-6f6e-4472-b8d0-765d73f121e7-at-jetpack/api-utils/lib/observer-service.js", line 35, in listener
    callback.call(target || callback, subject, data);
  File "resource://ef7cc3af-6f6e-4472-b8d0-765d73f121e7-at-jetpack/addon-kit/lib/selection.js", line 38, in 
    let selection = selections(window).selection;
TypeError: selections(window) is null

But it doesn't seem to break any test.

Comment 1

[Alexandre Poirot [:ochameau]]

Most likely introduced in:
https://github.com/mozilla/addon-sdk/commit/de5817464b4bb5472216aa648a944832aaf6a1d0

Comment 2

[Matteo Ferretti [:zer0] [:matteo]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/497

Pointer to Github pull-request

Comment 3

[Matteo Ferretti [:zer0] [:matteo]]

Comment on attachment 642710 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/497

Assigned Irakli as reviewer because he did the previous code's review.

Comment 4

[Matteo Ferretti [:zer0] [:matteo]]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/497/files

Pointer to Github pull-request

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/1725ab569665d75ce0d1f28ea7e76170c8d7063b
Merge pull request #497 from ZER0/selections-window-null/Bug774301

fix Bug 774301: Many "selections(window) is null" during tests r=@gozala

Comment 6

[[github robot]]

Commit pushed to stabilization at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/1725ab569665d75ce0d1f28ea7e76170c8d7063b
Merge pull request #497 from ZER0/selections-window-null/Bug774301