Closed
Bug 774301
Opened 12 years ago
Closed 12 years ago
Many "selections(window) is null" during tests
Categories
(Add-on SDK Graveyard :: General, defect, P1)
Add-on SDK Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
1.10
People
(Reporter: ochameau, Assigned: zer0)
Details
Attachments
(2 files)
We are currently seing many of this following exception: error: An exception occurred. Traceback (most recent call last): File "resource://ef7cc3af-6f6e-4472-b8d0-765d73f121e7-at-jetpack/api-utils/lib/system/events.js", line 58, in data: data File "resource://ef7cc3af-6f6e-4472-b8d0-765d73f121e7-at-jetpack/api-utils/lib/observer-service.js", line 35, in listener callback.call(target || callback, subject, data); File "resource://ef7cc3af-6f6e-4472-b8d0-765d73f121e7-at-jetpack/addon-kit/lib/selection.js", line 38, in let selection = selections(window).selection; TypeError: selections(window) is null But it doesn't seem to break any test.
Reporter | ||
Comment 1•12 years ago
|
||
Most likely introduced in: https://github.com/mozilla/addon-sdk/commit/de5817464b4bb5472216aa648a944832aaf6a1d0
Assignee | ||
Updated•12 years ago
|
Assignee: nobody → zer0
Assignee | ||
Comment 2•12 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Comment 3•12 years ago
|
||
Comment on attachment 642710 [details] Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/497 Assigned Irakli as reviewer because he did the previous code's review.
Attachment #642710 -
Flags: review?(rFobic)
Assignee | ||
Comment 4•12 years ago
|
||
Pointer to Github pull-request
Updated•12 years ago
|
Attachment #642710 -
Flags: review?(rFobic) → review+
Updated•12 years ago
|
Target Milestone: --- → 1.10
Comment 5•12 years ago
|
||
Commit pushed to master at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/1725ab569665d75ce0d1f28ea7e76170c8d7063b Merge pull request #497 from ZER0/selections-window-null/Bug774301 fix Bug 774301: Many "selections(window) is null" during tests r=@gozala
Status: NEW → RESOLVED
Closed: 12 years ago
Priority: -- → P1
Resolution: --- → FIXED
Comment 6•12 years ago
|
||
Commit pushed to stabilization at https://github.com/mozilla/addon-sdk https://github.com/mozilla/addon-sdk/commit/1725ab569665d75ce0d1f28ea7e76170c8d7063b Merge pull request #497 from ZER0/selections-window-null/Bug774301
You need to log in
before you can comment on or make changes to this bug.
Description
•