Closed
Bug 774464
Opened 12 years ago
Closed 12 years ago
JSScript::setSourceMap improperly handles OOM
Categories
(Core :: JavaScript Engine, defect)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
mozilla17
People
(Reporter: fitzgen, Unassigned)
Details
Attachments
(1 file)
|
429 bytes,
patch
|
jimb
:
review+
|
Details | Diff | Splinter Review |
When |putNew| fails, it deletes the whole |sourceMapMap| when there could be other entries in there. It should not do this.
|
Reporter | |
Comment 1•12 years ago
|
||
Attachment #642731 -
Flags: review?(jimb)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 642731 [details] [diff] [review]
v1
Review of attachment 642731 [details] [diff] [review]:
-----------------------------------------------------------------
::: js/src/jsscript.cpp
@@ -857,3 @@
> }
>
> if (!map->putNew(this, sourceMap)) {
The braces here can be dropped now.
|
||
Comment 3•12 years ago
|
||
Comment on attachment 642731 [details] [diff] [review]
v1
Review of attachment 642731 [details] [diff] [review]:
-----------------------------------------------------------------
This is fine, with the braces dropped as suggested.
Attachment #642731 -
Flags: review?(jimb) → review+
|
|
||
Comment 4•12 years ago
|
||
Status: NEW → ASSIGNED
Flags: in-testsuite-
OS: Mac OS X → All
Hardware: x86 → All
Target Milestone: --- → mozilla17
|
||
Comment 5•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•