774550 - DOM bindings don't get rebuilt if their dependencies change but the text doesn't change

Status: RESOLVED DUPLICATE of bug 784812

Description

[:Ehsan Akhgari]

I did the following:

* edit dom/bindings/Bindings.conf.
* edit dom/webidl/Perfromance*.webidl
* make -C objdir/dom

make finished running without rebuilding anything.

Comment 1

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Hmm.  Bindings.conf is explicitly listed in bindinggen_dependencies.

Did the changes lead to exactly the same code being generated?  There's some weirdness where we don't create the new C++ and header files if they end up being string-identical to what we used to have....

Comment 2

[:Ehsan Akhgari]

(In reply to comment #1)
> Hmm.  Bindings.conf is explicitly listed in bindinggen_dependencies.
> 
> Did the changes lead to exactly the same code being generated?  There's some
> weirdness where we don't create the new C++ and header files if they end up
> being string-identical to what we used to have....

Hmm, maybe.  I was trying to move the infallible annotations to the WebIDL files, and I guess that didn't change the exact code generated, right?  Still, this is totally unintuitive.

Comment 3

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Yeah, indeed, moving the annotations wouldn't change the code.

I agree it's screwed up.  I thought Kyle had an existing bug on it...

Comment 4

[Kyle Huey [:khuey] (Exited; not receiving bugmail, email if necessary)]

Only in my mind.

Comment 5

[Boris Zbarsky [:bzbarsky, bz on IRC]]

OK, let's make this that bug, then!