Makefile.in files should not have $(shell) per bug 769390. browser/locales/Makefile.in has a $(shell) on line 44 (setting APP_VERSION). There is a nice comment saying this might be unused. Other parts of the build system use: APP_VERSION = @MOZ_APP_VERSION@ We should switch to that or something similar (assuming this is still needed, which it may not be).
Yeah, this might be unused, historic raisins are http://bonsai.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&root=/cvsroot&subdir=mozilla/browser/locales&command=DIFF_FRAMESET&file=Makefile.in&rev2=1.3&rev1=1.2, and the DEFINES part is now in l10n.mk and used MOZ_APP_VERSION.
Created attachment 650474 [details] [diff] [review] Remove $(shell) from browser/locales/Makefile.in
Comment on attachment 650474 [details] [diff] [review] Remove $(shell) from browser/locales/Makefile.in AFAICT, everything that is included from this makefile use MOZ_APP_VERSION directly. Just remove the variable (and the comment). r+ if you do that.
Created attachment 650753 [details] [diff] [review] Remove $(shell) from browser/locales/Makefile.in (v2) Note to all: While it does say to Remove $(shell); there are two instances in this file. The first one, I just removed with this patch. The second one, as far as I've been told, isn't easy to remove (if it is at all possible to remove or made into a Variable. (my Makefile-fu is beginners).
Created attachment 650754 [details] [diff] [review] Remove $(shell) from browser/locales/Makefile.in (v3) w/ review attribution...
Pushed to mozilla-inbound: https://hg.mozilla.org/integration/mozilla-inbound/rev/1022af7974c9