774611 - Screen and Mouse resolution adjustment doesn't work correctly on release branches (incorrect url)

Status: VERIFIED FIXED

(Release Engineering :: General, defect)

Description

[Mark Banner (:standard8)]

Since bug 712630 was fixed, we've been using it on Thunderbird to fix the screen resolutions on comm-central for our tests.

Now we've migrated those to comm-aurora, we're getting failures again. The URL used to find the screen resolution file, doesn't take account of the extra 'releases/' required for aurora, beta, release etc, here's an extract from the log:

========= Started 'C:\mozilla-build\python25\python.exe c:/talos-slave/test/tools/scripts/support/mouse_and_screen_resolution.py ...' (results: 0, elapsed: 5 secs) (at 2012-07-17 02:44:16.688573) =========
'C:\\mozilla-build\\python25\\python.exe' 'c:/talos-slave/test/tools/scripts/support/mouse_and_screen_resolution.py' '--configuration-url' u'http://hg.mozilla.org/comm-aurora/raw-file/e442aac96ecb/testing/machine-configuration.json'
 in dir c:\talos-slave\test\build (timeout 1200 secs)
 watching logfiles {}
 argv: ['C:\\mozilla-build\\python25\\python.exe', 'c:/talos-slave/test/tools/scripts/support/mouse_and_screen_resolution.py', '--configuration-url', u'http://hg.mozilla.org/comm-aurora/raw-file/e442aac96ecb/testing/machine-configuration.json']
 environment:
  ALLUSERSPROFILE=C:\ProgramData
  APPDATA=C:\Users\cltbld\AppData\Roaming
  COMMONPROGRAMFILES=C:\Program Files\Common Files
  COMPUTERNAME=TALOS-R3-W7-043
  COMSPEC=C:\Windows\system32\cmd.exe
  FP_NO_HOST_CHECK=NO
  HOMEDRIVE=C:
  HOMEPATH=\Users\cltbld
  LOCALAPPDATA=C:\Users\cltbld\AppData\Local
  LOGONSERVER=\\TALOS-R3-W7-043
  MOZ_CRASHREPORTER_NO_REPORT=1
  MOZ_NO_REMOTE=1
  NO_EM_RESTART=1
  NUMBER_OF_PROCESSORS=2
  OS=Windows_NT
  PATH=C:\mozilla-build;C:\mozilla-build\msys\bin;C:\mozilla-build\msys\local\bin;C:\mozilla-build\buildbotve\scripts;C:\mozilla-build\Python25;C:\mozilla-build\Python25\Scripts;C:\mozilla-build\hg;C:\mozilla-build\7zip;C:\mozilla-build\upx203w;C:\WINDOWS\System32\Wbem;C:\WINDOWS\System32;C:\WINDOWS;
  PATHEXT=.COM;.EXE;.BAT;.CMD;.VBS;.VBE;.JS;.JSE;.WSF;.WSH;.MSC
  PROCESSOR_ARCHITECTURE=x86
  PROCESSOR_IDENTIFIER=x86 Family 6 Model 23 Stepping 10, GenuineIntel
  PROCESSOR_LEVEL=6
  PROCESSOR_REVISION=170a
  PROGRAMDATA=C:\ProgramData
  PROGRAMFILES=C:\Program Files
  PROMPT=$P$G
  PSMODULEPATH=C:\Windows\system32\WindowsPowerShell\v1.0\Modules\
  PUBLIC=C:\Users\Public
  PWD=c:\talos-slave\test\build
  SYSTEMDRIVE=C:
  SYSTEMROOT=C:\Windows
  TEMP=C:\Users\cltbld\AppData\Local\Temp
  TMP=C:\Users\cltbld\AppData\Local\Temp
  USERDOMAIN=TALOS-R3-W7-043
  USERNAME=cltbld
  USERPROFILE=C:\Users\cltbld
  WINDIR=C:\Windows
  XPCOM_DEBUG_BREAK=warn
 using PTY: False
This branch does not seem to have the configuration file HTTP Error 404: Not Found
Let's fail over to 1024x768.
Screen resolution (current): (1280, 1024)
Changing the screen resolution...
Screen resolution (new): (1024, 768)
Mouse position (current): (512, 384)
Mouse position (new): (1010, 10)
program finished with exit code 0
elapsedTime=5.827000
========= Finished 'C:\mozilla-build\python25\python.exe c:/talos-slave/test/tools/scripts/support/mouse_and_screen_resolution.py ...' (results: 0, elapsed: 5 secs) (at 2012-07-17 02:44:22.542910) =========

Comment 1

[Armen [:armenzg]]

Attachment: fix repoPath for aurora and comm branches

It seems that the value of repoPath has been broken for a while for aurora and comm branches.

Comment 2

[Mark Banner (:standard8)]

Looks like armenzg forgot to land this, can we get it landed in his absence?

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 642955 [details] [diff] [review]
fix repoPath for aurora and comm branches

http://hg.mozilla.org/build/buildbot-configs/rev/a0197e6f37a7

Comment 4

[Rail Aliiev [:rail]]

In production.

Comment 5

[Rail Aliiev [:rail]]

Comment on attachment 642955 [details] [diff] [review]
fix repoPath for aurora and comm branches

Had to backout due to scheduling issues...

http://hg.mozilla.org/build/buildbot-configs/rev/5242aa19836a

Comment 6

[Rail Aliiev [:rail]]

So, the patch enabled release tests on mozilla-aurora, what caused huuuuge delays in test scheduling. You'll need to explicitly set repo_path.

Comment 7

[Rail Aliiev [:rail]]

Or even better, get rid of release_branch variable which controls 3 other variables and set the corresponding variables for every release branch.

Comment 8

[Mark Banner (:standard8)]

Attachment: Possible alternative

As armenzg is afk at the moment, how about something like this?

It keeps release_branch but makes that exclusively for the repoPath. Then adds release_tests to the BRANCHES objects which sets that number appropriately.

Comment 9

[Rail Aliiev [:rail]]

Comment on attachment 654135 [details] [diff] [review]
Possible alternative

I'd prefer to get rid of evil loops here. I'll attach a patch in a bit which removes the loops and sets those vars explicitly.

Comment 10

[Rail Aliiev [:rail]]

Attachment: get rid of "release_branch" variable

This fixes repo_path for mozilla-aurora only.

This is the diff between old and new config dump.
https://gist.github.com/3428756

Comment 11

[Mark Banner (:standard8)]

Comment on attachment 654335 [details] [diff] [review]
get rid of "release_branch" variable

repo_path will need fixing for in thunderbird_config.py as for the release branches, it isn't set to anything with this patch.

Comment 12

[Rail Aliiev [:rail]]

Attachment: TB configs

I have some concern about ['release_tests'] = 5 and ['platforms']['linux']['enable_mobile_unittests'] = True... When we landed the initial patch for aurora, we had a headache with test scheduling...

Comment 13

[[e-mail] (:bhearsum)]

Comment on attachment 654335 [details] [diff] [review]
get rid of "release_branch" variable

Take that, dirty hack!

Comment 14

[Rail Aliiev [:rail]]

Comment on attachment 654335 [details] [diff] [review]
get rid of "release_branch" variable

http://hg.mozilla.org/build/buildbot-configs/rev/16cd281f5470

Comment 15

[Rail Aliiev [:rail]]

Attachment: TB configs

The patch fixes repo_path for Thunderbird.

I didn't enable release_tests for comm-{release,beta} because of possible extra load when we deploy it. Let me know if you need that parameter, so we land it with extra caution.

Comment 16

[Mark Banner (:standard8)]

Comment on attachment 654599 [details] [diff] [review]
TB configs

Looks good, afaict release_tests is actually only for talos tests, which we don't run anyway, so I'm fine with those not being added :-)

Comment 17

[Rail Aliiev [:rail]]

Comment on attachment 654599 [details] [diff] [review]
TB configs

http://hg.mozilla.org/build/buildbot-configs/rev/acbf9ac9ca27

Comment 18

[Chris Cooper [:coop] (he/him)]

This made it into production today.

Comment 19

[Mark Banner (:standard8)]

Just verified this on comm-aurora for Thunderbird and it is working fine. Thanks.