774648 - MultiChoicePreference should grey out the Positive option if no checkboxes are selected

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Cristian Nicolae (:xti)]

Attachment: screenshot

Firefox 17.a1 (2012-07-17)
Device: Galaxy Nexus
OS: Android 4.0.4

Steps to reproduce:
1. Open Firefox
2. Go to Menu > Settings > Import from Android
3. Uncheck Bookmarks and History

Expected result:
Import button is grayed out.

Actual result:
Import button is still active, as you can see in the attached screenshot.

Comment 1

[Aaron Train [:aaronmt]]

On import, I see I/AndroidImport(n): Importing Android history/bookmarks, but no items are imported.

Comment 2

[Gian-Carlo Pascutto [:gcp]]

You'll get that message if the routine is activated, no matter if it ends up doing anything or not.

Comment 3

[Brian Nicholson (:bnicholson)]

Attachment: Enable positive button in MultiChoicePreference only if items are checked

It's possible we may still want to show a dialog where the button can be clicked even if all options are deselected, but we can just address that if/when we need it in the future.

Comment 4

[Brian Nicholson (:bnicholson)]

Attachment: Enable positive button in MultiChoicePreference only if items are checked, v2

Some minor changes (uses break instead of early return, and only sets enabled state if it has changed).2

Comment 5

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 643114 [details] [diff] [review]
Enable positive button in MultiChoicePreference only if items are checked, v2

Need uplift to aurora and beta?

Comment 6

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/integration/mozilla-inbound/rev/d3fc89f462d2

Comment 7

[Brian Nicholson (:bnicholson)]

Comment on attachment 643114 [details] [diff] [review]
Enable positive button in MultiChoicePreference only if items are checked, v2

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 754335
User impact if declined: use can choose to clear private data or import from Android without anything checked
Testing completed (on m-c, etc.): just landed m-i
Risk to taking this patch (and alternatives if risky): low risk
String or UUID changes made by this patch: none

Comment 8

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/d3fc89f462d2

Comment 9

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/985eaf394b52

Comment 10

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/releases/mozilla-beta/rev/23394d756bda

Comment 11

[Scoobidiver (away)]

It should be backed out from 15.0b2 because of the regression.

Comment 12

[Scoobidiver (away)]

Based on Brian's dependency cut, forget comment 11.

Comment 13

[Aaron Train [:aaronmt]]

Confused, I see this landed on mozilla-beta, but the changes are not in the mozilla-beta (15, beta 2, build #1) build. What happened?

Comment 14

[Gian-Carlo Pascutto [:gcp]]

You might be seeing this:
https://bugzilla.mozilla.org/show_bug.cgi?id=769896

Comment 15

[Aaron Train [:aaronmt]]

Confirmed, verifying this by using the 'Clear private data' popup.