Last Comment Bug 774666 - Twitter avatars from past tweets in stream not visible after opening chat tab in new window
: Twitter avatars from past tweets in stream not visible after opening chat tab...
Status: RESOLVED FIXED
:
Product: Thunderbird
Classification: Client Software
Component: Instant Messaging (show other bugs)
: Trunk
: x86 All
: -- normal (vote)
: Thunderbird 17.0
Assigned To: Mike Conley (:mconley) - (needinfo me!)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-17 08:09 PDT by Mike Conley (:mconley) - (needinfo me!)
Modified: 2012-07-17 14:00 PDT (History)
2 users (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
fixed
fixed


Attachments
Patch v1 (637 bytes, patch)
2012-07-17 09:16 PDT, Mike Conley (:mconley) - (needinfo me!)
florian: review+
standard8: approval‑comm‑aurora+
standard8: approval‑comm‑beta+
Details | Diff | Splinter Review

Description Mike Conley (:mconley) - (needinfo me!) 2012-07-17 08:09:14 PDT
STR:

1)  Open a Twitter stream in a chat tab. Ensure that you can see the user avatars for each tweet
2)  Open the chat tab in a new window (open a message in a tab, move to new window, open chat tab)

What happens?

The avatars are missing in the Twitter stream in the new tab. New tweets contain avatars though.

What's expected?

The avatars should be visible in both windows when the new chat tab is opened.
Comment 1 Mike Conley (:mconley) - (needinfo me!) 2012-07-17 09:16:11 PDT
Created attachment 642994 [details] [diff] [review]
Patch v1
Comment 2 Florian Quèze [:florian] [:flo] 2012-07-17 10:16:35 PDT
Comment on attachment 642994 [details] [diff] [review]
Patch v1

This looks good to me (I only looked at the patch, I haven't tried it). If Andreas wasn't on vacations I would want him to look at the patch too, but I guess I'll just CC him so that he can double check after the fact.

Note You need to log in before you can comment on or make changes to this bug.