77467 - Prompt service considers 0 a string instead of null

Status: VERIFIED FIXED

(Core Graveyard :: Embedding: APIs, defect, P1)

Description

[Blake Ross]

A bunch of prompts now come up with initial values of 0 due to the change to 
nsIPromptService.  The initial value is now an inout object, and when this 
change was done this object was set to a default value of 0 (in some cases this 
was done incorrectly, as shown in the url above in this report -- the 0-valued 
object used for the checkbox result was instead used for the initial value).  
However, the prompt service seems to consider this a string.  I think 0 should 
be null and '0' or "0" a string, but if we don't want to do that, please fix 
the callers' objects to have null values.

Comment 1

[Blake Ross]

-> Conrad

Comment 2

[Conrad Carlen (not reading bugmail)]

Oof, I was wrong. When the callers want to pass a null inout string, they should
pass {value:null} instead of {value:0}. Fixed search-editor.js. Will find other
occurances of this and post a patch.

Comment 3

[Conrad Carlen (not reading bugmail)]

Attachment: Fixes the callers

Comment 4

[Conrad Carlen (not reading bugmail)]

Blake - can you review? I think I found all the callers by searching for
"prompt" in *.js in my tree. Let me know if I missed something.

Comment 5

[Blake Ross]

Thanks for fixing, r=blake

Comment 6

[Conrad Carlen (not reading bugmail)]

CC'ing Alec for sr.

Comment 7

[Alec Flett]

sr=alecf

Comment 8

[Conrad Carlen (not reading bugmail)]

Fix checked in.

Comment 9

[Fabian Guisset]

*** Bug 75483 has been marked as a duplicate of this bug. ***

Comment 10

[David Epstein]

reassign qa contact to Dharma. He's working with prompts.

Comment 11

[dsirnapalli]

verified pref-formatting.js and editor.js.the initial values have been changed 
to null instead of 0. marking the bug verified.