Closed Bug 774675 Opened 13 years ago Closed 12 years ago

Redirect /es/ to /es-ES/ on www.mozilla.org

Categories

(www.mozilla.org :: General, defect)

Product:
www.mozilla.org
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
VERIFIED FIXED

People

(Reporter: retornam, Assigned: pmac)

References

(Blocks 1 open bug,
URL
)

Details

(Whiteboard: [kb=1149203] )

Attachments

(1 file)

pull request
44 bytes, text/x-github-pull-request
Details | Review
https://www.mozilla.org/es/firefox/fx/ fallsback to the es-ES page so it should return a 302 instead of a 404
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
Ahhh, http://www.mozilla.org/es/firefox/new/ is also 404. This should be fixed ASAP.
Blocks: 745355
Severity: normal → critical
OS: Mac OS X → All
Hardware: x86 → All
I agree it should be fixed sooner than later, but the "es" locale doesn't really exist, so unless someone has this exact link they'll never hit this.
Severity: critical → normal
Should this page be redirected to the es-ES equivalent?
We should just redirect /es/ to /es-ES/ on all of mozilla.org. /es/firefox/* is getting about 100-500 views a day.
Summary: https://www.mozilla.org/es/firefox/fx/ returns 404 status code even though it falls back to es-ES → Redirect /es/ to /es-ES/ on www.mozilla.org
on the php site /es/ was equivalent to /es-ES/ example: https://www.mozilla.org/es/firefox/channel So +1 on what Chris said.
Whiteboard: [kb=1149203]
Are there other locales we should give this treatment while we're at it? "en", "pt", "zh"?
Assignee: nobody → pmac
Status: NEW → ASSIGNED
Flags: needinfo?(pascalc)
en -> en-US pt -> pt-BR For zh, we wouldn't have a clear winner between zh-TW and zh-CN. I don't think we have other 'international' locales in a similar position.
Flags: needinfo?(pascalc)
Attached file pull request —
Seems to be working well on demo1: $ curl -IL www-demo1.allizom.org/pt/firefox/new/ HTTP/1.1 301 Moved Permanently Content-Type: text/html Date: Mon, 04 Nov 2013 20:27:58 GMT Location: https://www-demo1.allizom.org/pt/firefox/new/ Connection: Keep-Alive Content-Length: 0 HTTP/1.1 301 Moved Permanently Server: Apache X-Backend-Server: bedrock1.dev.webapp.phx1.mozilla.com Vary: Accept-Encoding Content-Type: text/html; charset=iso-8859-1 Date: Mon, 04 Nov 2013 20:27:58 GMT Location: https://www-demo1.allizom.org/pt-BR/firefox/new/ Transfer-Encoding: chunked Connection: Keep-Alive HTTP/1.1 200 OK Server: Apache X-Backend-Server: bedrock1.dev.webapp.phx1.mozilla.com Vary: Accept-Encoding Cache-Control: max-age=600 Content-Type: text/html; charset=utf-8 Date: Mon, 04 Nov 2013 20:27:58 GMT Expires: Mon, 04 Nov 2013 20:37:59 GMT Transfer-Encoding: chunked Connection: Keep-Alive X-Robots-Tag: noodp X-Frame-Options: DENY
(In reply to Paul McLanahan [:pmac] from comment #9) > Seems to be working well on demo1: > > $ curl -IL www-demo1.allizom.org/pt/firefox/new/ > HTTP/1.1 301 Moved Permanently > Content-Type: text/html > Date: Mon, 04 Nov 2013 20:27:58 GMT > Location: https://www-demo1.allizom.org/pt/firefox/new/ > Connection: Keep-Alive > Content-Length: 0 > > HTTP/1.1 301 Moved Permanently > Server: Apache > X-Backend-Server: bedrock1.dev.webapp.phx1.mozilla.com > Vary: Accept-Encoding > Content-Type: text/html; charset=iso-8859-1 > Date: Mon, 04 Nov 2013 20:27:58 GMT > Location: https://www-demo1.allizom.org/pt-BR/firefox/new/ > Transfer-Encoding: chunked > Connection: Keep-Alive > > HTTP/1.1 200 OK > Server: Apache > X-Backend-Server: bedrock1.dev.webapp.phx1.mozilla.com > Vary: Accept-Encoding > Cache-Control: max-age=600 > Content-Type: text/html; charset=utf-8 > Date: Mon, 04 Nov 2013 20:27:58 GMT > Expires: Mon, 04 Nov 2013 20:37:59 GMT > Transfer-Encoding: chunked > Connection: Keep-Alive > X-Robots-Tag: noodp > X-Frame-Options: DENY pmac push to stage?
:retornam not on master yet. Still want someone to test this manually a bit more and give me an r+ on the apache config itself. Perhaps :jgmize could do that?
Flags: needinfo?(jmize)
my tests with curl look good. I'll leave the regex stuff to :jgmizw
Commits pushed to master at https://github.com/mozilla/bedrock https://github.com/mozilla/bedrock/commit/1a96c5561de0d64f543ca31cc3f7d9f702c03e87 Fix bug 774675: Redirect /es/* to /es-ES/* Also: * /en/ -> /en-US/ * /pt/ -> /pt-BR/ https://github.com/mozilla/bedrock/commit/6723a1380c2f9dde58566d5fe451fae16c8888d5 Merge pull request #1365 from pmclanahan/redirect-es-774675 Fix bug 774675: Redirect /es/* to /es-ES/*
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
r+, merged
Flags: needinfo?(jmize)
fixed on stage curl -I https://www.allizom.org/es/firefox/fx HTTP/1.1 301 Moved Permanently Server: Apache X-Backend-Server: bedrock1.stage.webapp.phx1.mozilla.com Vary: Accept-Encoding Content-Type: text/html; charset=iso-8859-1 Date: Tue, 05 Nov 2013 19:12:30 GMT Location: https://www.allizom.org/es-ES/firefox/fx Transfer-Encoding: chunked Connection: Keep-Alive
verified fixed curl -I mozilla.org/es/firefox/new HTTP/1.1 301 Moved Permanently Server: Apache X-Backend-Server: bedrock2.webapp.phx1.mozilla.com Vary: Accept-Encoding Content-Type: text/html; charset=iso-8859-1 Date: Tue, 05 Nov 2013 20:01:18 GMT Location: http://www.mozilla.org/es/firefox/new Transfer-Encoding: chunked Connection: Keep-Alive X-Cache-Info: caching
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: