Closed Bug 774696 Opened 10 years ago Closed 8 years ago

Default icon for applications listed on about:apps is not visible

Categories

(Firefox for Android Graveyard :: General, defect)

17 Branch
ARM
Android
defect
Not set
normal

Tracking

(firefox16 wontfix, firefox17 wontfix, firefox28 verified, fennec+)

VERIFIED FIXED
Firefox 28
Tracking Status
firefox16 --- wontfix
firefox17 --- wontfix
firefox28 --- verified
fennec + ---

People

(Reporter: aaronmt, Assigned: noppanit.c)

Details

(Whiteboard: [mentor=wesj][lang=js])

Attachments

(2 files)

Using an example test-manifest with either malformed or missing icons will not generate an icon (rocket ship) on about:apps

{
  "name":"Test App ({subdomain})",
  "icons":{
    "16":"http://testmanifest.com/xxxpng",
    "48":"http://testmanifest.com/yyy.png",
    "128":"http://testmanifest.com/zzz.png"
  }
}
Attached patch WIP PatchSplinter Review
Argh. I hate this code. getBiggestIcon doesn't do any checks to see if icons exist. So now here it does. With a callback.

I haven't tested this yet, but should work.
Assignee: nobody → wjohnston
tracking-fennec: ? → +
Status: NEW → ASSIGNED
This fell off the radar. I don't think this should block.
Not actively working on this.
Assignee: wjohnston → nobody
Whiteboard: [mentor=wesj][lang=js]
I'm new to this but can I give it a try and can I ask for someone to mentor me? Thanks a lot. I do Java and Javascript everyday at work.
Flags: needinfo?
(In reply to noppanit.c from comment #4)
> I'm new to this but can I give it a try and can I ask for someone to mentor
> me? Thanks a lot. I do Java and Javascript everyday at work.

Your best bet is to come onto #mobile and chat with WesJ.
Flags: needinfo?
Hi. I got some guideline from WesJ already. How do I assign this bug to myself?
Assignee: nobody → noppanit.c
Attached patch Bug-774696.diffSplinter Review
Attachment #825555 - Flags: review?(wjohnston)
Comment on attachment 825555 [details] [diff] [review]
Bug-774696.diff

Review of attachment 825555 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! Thanks!
Attachment #825555 - Flags: review?(wjohnston) → review+
https://hg.mozilla.org/mozilla-central/rev/5bd7d1c2f11b
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 28
Status: RESOLVED → VERIFIED
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.