Previous conversations sometimes not displayed

RESOLVED FIXED in Thunderbird 17.0

Status

Thunderbird
Instant Messaging
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: florian, Assigned: florian)

Tracking

Trunk
Thunderbird 17.0

Thunderbird Tracking Flags

(thunderbird15 fixed, thunderbird16 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 643016 [details] [diff] [review]
Patch

I've debugged a few cases where the "Daily currently doesn't have any previous conversations stored for this contact." panel was displayed instead of an existing previous conversation.

It happened when selecting a contact with a previous conversation, then a contact without previous conversation, then selecting the contact with a previous conversation again. This is because in my patch for bug 754914 I prevented redisplaying a previous conversation if it was already displayed in the browser, but I forgot to still ensure the log panel is visible.

The same thing can happen for the "Search result" item: the log panel isn't always shown correctly when reselecting that item.

And a last case causing a similar problem: closing the "search result" conversation, which actually just hides it. This attempts to select another conversation, but the mousedown event handler of listbox.xml immediately reselects it even though it is hidden, so when displaying it again the 'select' event isn't fired, as the item is already selected.
Attachment #643016 - Flags: review?(mconley)
Comment on attachment 643016 [details] [diff] [review]
Patch

Review of attachment 643016 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good - and I can confirm that this fixes the bug.
Attachment #643016 - Flags: review?(mconley) → review+
(Assignee)

Updated

5 years ago
Attachment #643016 - Flags: approval-comm-beta?
Attachment #643016 - Flags: approval-comm-aurora?
Comment on attachment 643016 [details] [diff] [review]
Patch

Yeah, I really think we want to have this on aurora/beta.
Attachment #643016 - Flags: approval-comm-beta?
Attachment #643016 - Flags: approval-comm-beta+
Attachment #643016 - Flags: approval-comm-aurora?
Attachment #643016 - Flags: approval-comm-aurora+
comm-central: https://hg.mozilla.org/comm-central/rev/b25917a2622e
comm-aurora: https://hg.mozilla.org/releases/comm-aurora/rev/b423b5dcf058
comm-beta: https://hg.mozilla.org/releases/comm-beta/rev/20b6906240f4
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-thunderbird15: --- → fixed
status-thunderbird16: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 17.0
You need to log in before you can comment on or make changes to this bug.