774787 - update mozilla-beta mozconfig comparisons

Status: RESOLVED FIXED

(Release Engineering :: Release Automation: Other, defect)

Description

[[e-mail] (:bhearsum)]

Attachment: update the whitelist

We had a few issues today with Fx + Tb:
WARNING : if test "$IS_NIGHTLY" != ""; then not in win32 ['ac_add_options --enable-update-channel=nightly', 'ac_add_options --enable-signmar', 'ac_add_options --enable-js-diagnostics', '. $topsrcdir/configs/mozilla2/win32/include/choose-make-flags', 'mk_add_options MOZ_MAKE_FLAGS=-j1']!
ERROR : found in browser/config/mozconfigs/win32/nightly but not in browser/config/mozconfigs/win32/release: if test "$IS_NIGHTLY" != ""; then
WARNING : ac_add_options --disable-auto-deps not in win32 ['ac_add_options --enable-update-channel=nightly', 'ac_add_options --enable-signmar', 'ac_add_options --enable-js-diagnostics', '. $topsrcdir/configs/mozilla2/win32/include/choose-make-flags', 'mk_add_options MOZ_MAKE_FLAGS=-j1']!
ERROR : found in browser/config/mozconfigs/win32/nightly but not in browser/config/mozconfigs/win32/release: ac_add_options --disable-auto-deps
WARNING : fi not in win32 ['ac_add_options --enable-update-channel=nightly', 'ac_add_options --enable-signmar', 'ac_add_options --enable-js-diagnostics', '. $topsrcdir/configs/mozilla2/win32/include/choose-make-flags', 'mk_add_options MOZ_MAKE_FLAGS=-j1']!
ERROR : found in browser/config/mozconfigs/win32/nightly but not in browser/config/mozconfigs/win32/release: fi
ERROR : Error verifying mozconfigs

AFAICT this is because this block is in the nightly mozconfig but not in release:
if test "$IS_NIGHTLY" != ""; then 
  ac_add_options --disable-auto-deps
fi

We should whitelist those three lines to fix this error.

Comment 1

[Rail Aliiev [:rail]]

Comment on attachment 643062 [details] [diff] [review]
update the whitelist

lgtm... however the format of the whitelist becomes less readable each time :/