774848 - Remove version requirement on sqlalchemy <= 0.6.99

Status: VERIFIED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Landry Breuil (:gaston)]

Followup to bug #654835, the requirement on sqlachemy <= 0.6.99 in -core, -reg and -storage doesnt seem to be needed anymore. I'm running sync server fine with sqlachemy 0.7.1, so i think the version requirement could be removed.

Comment 1

[Landry Breuil (:gaston)]

Attachment: Remove version dep on sqlalchemy (server-core)

Comment 2

[Landry Breuil (:gaston)]

Attachment: Remove version dep on sqlalchemy (server-reg)

Comment 3

[Landry Breuil (:gaston)]

Attachment: Remove version dep on sqlalchemy (server-storage)

Comment 4

[Ryan Kelly [:rfkelly]]

Thanks Landry.  I can confirm that this works with sqlite for the basic functional tests, I'll have to take it for a spin on MySQL as well before committing.  As another data point, what database are you using?

Comment 5

[Ryan Kelly [:rfkelly]]

Tests pass with mysql backend, including the custom code we have for doing DELETE with ORDER BY and LIMIT.  So let's push ahead with this.

In addition to removing the version limit in setup.py, it will also need to be removed in the dev-reqs.txt file in each repo.

Comment 6

[Landry Breuil (:gaston)]

(In reply to Ryan Kelly [:rfkelly] from comment #4)
> Thanks Landry.  I can confirm that this works with sqlite for the basic
> functional tests, I'll have to take it for a spin on MySQL as well before
> committing.  As another data point, what database are you using?

Plain default sqlite. I can do the commits/pushes if you want.

Comment 7

[Ryan Kelly [:rfkelly]]

Committed in:

http://hg.mozilla.org/services/server-core/rev/3368df843ace

http://hg.mozilla.org/services/server-reg/rev/bc78d75507b0

http://hg.mozilla.org/services/server-storage/rev/6e866ec0079e

Comment 8

[Ryan Kelly [:rfkelly]]

QA please verify this by checking that all tests pass with a fresh build of server-full.  You'll need to build with CHANNEL=dev, and check that the version of sqlalchemy it built with is something in the 0.7 series.  Do this to view the version:

    ./bin/pip freeze | grep SQLAlchemy

Also note that we haven't actually bumped the version of SQLAlchemy we're using in production.  I've filed Bug 787278 to track that.

Comment 9

[James Bonacci [:jbonacci]]

So for a local install, I run the following from server-full:
$ ./bin/pip freeze | grep SQLAlchemy
SQLAlchemy==0.7.8

Verified.