774891 - Default to correct config file paths in run.py

Status: RESOLVED FIXED

(Cloud Services Graveyard :: Server: Sync, defect)

Description

[Ryan Kelly [:rfkelly]]

Currently our run.py scripts default to e.g. /etc/aitc/production.ini for the config file, but we change this with an environment variable in production to be /etc/mozilla-services/aitc/production.ini.  We should just default to the correct path.

Comment 1

[Ryan Kelly [:rfkelly]]

Attachment: patch to load production .ini from correct location

Patch updating server-aitc to look in the correct place for the production .ini file.  :bobm does this look right to you?

I will also make a corresponding change for syncstorage.

Comment 2

[Bob Micheletto [:bobm]]

Comment on attachment 654109 [details] [diff] [review]
patch to load production .ini from correct location

Looks good to me.  What is the purpose of the fallback to tests.ini?  Wouldn't we want it to break in production if the .ini file was missing?  Or will it be very _vocal_ about using tests.ini?

Comment 3

[Ryan Kelly [:rfkelly]]

(In reply to Bob Micheletto [:bobm] from comment #2)
> Looks good to me.  What is the purpose of the fallback to tests.ini? 
> Wouldn't we want it to break in production if the .ini file was missing?  Or
> will it be very _vocal_ about using tests.ini?

Hmmm...the original intention was to be able to run a test server without having to configure anything.  You're right though, this does seem like it could be dangerous by masking errors and/or running with an insecure config by accident.

Comment 4

[Ryan Kelly [:rfkelly]]

Attachment: patch to load production .ini from correct location, raising error if not found

This patch raises a descriptive error message instead of falling back to the testing config file.

Comment 5

[Ryan Kelly [:rfkelly]]

https://github.com/mozilla-services/server-aitc/commit/2e8bc35ba6ffa9e37a63d4fd6dbaa9f83faf90e3

https://github.com/mozilla-services/server-syncstorage/commit/28c562bf3ca0a5bbd8c07c1ccae381345ff2ece0