774978 - Unable to pull profiles on Android Fennec

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Benoit Girard (:BenWa)]

The extension fails to read the profile from NS_OS_TEMP_DIR on android fennec while it works fine when the code is patches to write to '/data/local'.

Comment 1

[Mike Hommey [:glandium]]

are you able to pull e.g. /data/data/org.mozilla.fennec/lib/libmozglue.so?

Comment 2

[Benoit Girard (:BenWa)]

No:
bgirard@bulldozer:~/mozilla/kiwifox/tree$ adb pull /data/data/org.mozilla.fennec_bgirard/libmozglue.so .
remote object '/data/data/org.mozilla.fennec_bgirard/libmozglue.so' does not exist
bgirard@bulldozer:~/mozilla/kiwifox/tree$ adb pull /data/data/org.mozilla.fennec/libmozglue.so .
remote object '/data/data/org.mozilla.fennec/libmozglue.so' does not exist

Comment 3

[Benoit Girard (:BenWa)]

Attachment: Restore /sdcard for now

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 645344 [details] [diff] [review]
Restore /sdcard for now

Review of attachment 645344 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/profiler/TableTicker.cpp
@@ +454,5 @@
>      t->SetPaused(true);
>  
>      // Get file path
> +#ifdef ANDROID
> +    nsCString tmpPath = NS_LITERAL_CSTRING("/sdcard/");

Make that an nsCAutoString. I also think you can skip the assignment part, and just make /sdcard/ part of the AppendPrintf.

Comment 5

[Benoit Girard (:BenWa)]

Attachment: Restore /sdcard for now

Carry forward r+

Comment 6

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/7bf11bf3d11f

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/7bf11bf3d11f