Last Comment Bug 774978 - Unable to pull profiles on Android Fennec
: Unable to pull profiles on Android Fennec
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Gecko Profiler (show other bugs)
: Trunk
: x86 Mac OS X
: -- normal (vote)
: mozilla17
Assigned To: Benoit Girard (:BenWa)
:
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-17 21:41 PDT by Benoit Girard (:BenWa)
Modified: 2012-07-25 08:12 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Restore /sdcard for now (1.44 KB, patch)
2012-07-24 09:28 PDT, Benoit Girard (:BenWa)
mh+mozilla: review+
Details | Diff | Splinter Review
Restore /sdcard for now (1.42 KB, patch)
2012-07-24 10:26 PDT, Benoit Girard (:BenWa)
b56girard: review+
Details | Diff | Splinter Review

Description Benoit Girard (:BenWa) 2012-07-17 21:41:09 PDT
The extension fails to read the profile from NS_OS_TEMP_DIR on android fennec while it works fine when the code is patches to write to '/data/local'.
Comment 1 Mike Hommey [:glandium] 2012-07-17 22:40:58 PDT
are you able to pull e.g. /data/data/org.mozilla.fennec/lib/libmozglue.so?
Comment 2 Benoit Girard (:BenWa) 2012-07-24 08:44:56 PDT
No:
bgirard@bulldozer:~/mozilla/kiwifox/tree$ adb pull /data/data/org.mozilla.fennec_bgirard/libmozglue.so .
remote object '/data/data/org.mozilla.fennec_bgirard/libmozglue.so' does not exist
bgirard@bulldozer:~/mozilla/kiwifox/tree$ adb pull /data/data/org.mozilla.fennec/libmozglue.so .
remote object '/data/data/org.mozilla.fennec/libmozglue.so' does not exist
Comment 3 Benoit Girard (:BenWa) 2012-07-24 09:28:48 PDT
Created attachment 645344 [details] [diff] [review]
Restore /sdcard for now
Comment 4 Mike Hommey [:glandium] 2012-07-24 09:49:08 PDT
Comment on attachment 645344 [details] [diff] [review]
Restore /sdcard for now

Review of attachment 645344 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/profiler/TableTicker.cpp
@@ +454,5 @@
>      t->SetPaused(true);
>  
>      // Get file path
> +#ifdef ANDROID
> +    nsCString tmpPath = NS_LITERAL_CSTRING("/sdcard/");

Make that an nsCAutoString. I also think you can skip the assignment part, and just make /sdcard/ part of the AppendPrintf.
Comment 5 Benoit Girard (:BenWa) 2012-07-24 10:26:48 PDT
Created attachment 645362 [details] [diff] [review]
Restore /sdcard for now

Carry forward r+
Comment 7 Ed Morley [:emorley] 2012-07-25 08:12:10 PDT
https://hg.mozilla.org/mozilla-central/rev/7bf11bf3d11f

Note You need to log in before you can comment on or make changes to this bug.