Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Unable to pull profiles on Android Fennec

RESOLVED FIXED in mozilla17

Status

()

Core
Gecko Profiler
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: BenWa, Assigned: BenWa)

Tracking

Trunk
mozilla17
x86
Mac OS X
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

5 years ago
The extension fails to read the profile from NS_OS_TEMP_DIR on android fennec while it works fine when the code is patches to write to '/data/local'.
are you able to pull e.g. /data/data/org.mozilla.fennec/lib/libmozglue.so?
(Assignee)

Comment 2

5 years ago
No:
bgirard@bulldozer:~/mozilla/kiwifox/tree$ adb pull /data/data/org.mozilla.fennec_bgirard/libmozglue.so .
remote object '/data/data/org.mozilla.fennec_bgirard/libmozglue.so' does not exist
bgirard@bulldozer:~/mozilla/kiwifox/tree$ adb pull /data/data/org.mozilla.fennec/libmozglue.so .
remote object '/data/data/org.mozilla.fennec/libmozglue.so' does not exist
(Assignee)

Comment 3

5 years ago
Created attachment 645344 [details] [diff] [review]
Restore /sdcard for now
Attachment #645344 - Flags: review?(mh+mozilla)
Comment on attachment 645344 [details] [diff] [review]
Restore /sdcard for now

Review of attachment 645344 [details] [diff] [review]:
-----------------------------------------------------------------

::: tools/profiler/TableTicker.cpp
@@ +454,5 @@
>      t->SetPaused(true);
>  
>      // Get file path
> +#ifdef ANDROID
> +    nsCString tmpPath = NS_LITERAL_CSTRING("/sdcard/");

Make that an nsCAutoString. I also think you can skip the assignment part, and just make /sdcard/ part of the AppendPrintf.
Attachment #645344 - Flags: review?(mh+mozilla) → review+
(Assignee)

Comment 5

5 years ago
Created attachment 645362 [details] [diff] [review]
Restore /sdcard for now

Carry forward r+
Assignee: nobody → bgirard
Status: NEW → ASSIGNED
Attachment #645362 - Flags: review+
(Assignee)

Comment 6

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/7bf11bf3d11f

Comment 7

5 years ago
https://hg.mozilla.org/mozilla-central/rev/7bf11bf3d11f
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla17
You need to log in before you can comment on or make changes to this bug.