775042 - Download history is not cleared when clearing private data

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Description

[Adrian Tamas (:AdrianT)]

Nightly 17.0a1 2012-07-17/ Firefox Mobile 15.0b1
Device: HTC Desire (Android 2.2)/Samsung Galaxy S2 (Android 2.3.4)

Steps to reproduce:
1. Go to 1.usa.gov/deeXKM.
2. Wait for the pdf to finish download.
3. Return to Firefox Mobile and clear private data. Make sure "Browsing&Download History" is selected.
4. Open the Download Manager.

Expected results:
The download history is cleared.

Actual results:
All downloads are still displayed in the Download Manager.

Comment 1

[Brian Nicholson (:bnicholson)]

Attachment: Clear downloads when clearing history

This one is simple enough.

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 643641 [details] [diff] [review]
Clear downloads when clearing history

This could get confusing if we continue to create the special groups. We might want to create special names too and handle all sub items in an if check. Like this:

switch (key) {
  case "history+downloads":
    sanitizer.clearItem("history");
    sanitizer.clearItem("downloads");
    break;
  default:
    sanitizer.clearItem(key);
}

Thoughts? I'd be ok with landing this fix as is on 16 and 15, and looking for something more robust in 17.

Comment 3

[Adrian Tamas (:AdrianT)]

Test case is included in the Firefox Mobile: Privacy & Content Managing test suit. Test case link:
https://moztrap.mozilla.org/manage/cases/?filter-id=798#caseversion-id-1403

Comment 4

[Brian Nicholson (:bnicholson)]

Landed with special names as described in comment 2:

http://hg.mozilla.org/integration/mozilla-inbound/rev/085db75952bb

Comment 5

[Brian Nicholson (:bnicholson)]

Comment on attachment 643641 [details] [diff] [review]
Clear downloads when clearing history

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 754335
User impact if declined: download history cannot be cleared
Testing completed (on m-c, etc.): just landed m-i
Risk to taking this patch (and alternatives if risky): low
String or UUID changes made by this patch: none

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/085db75952bb

Comment 7

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/releases/mozilla-aurora/rev/4c78d5d0a5b7

Comment 8

[Brian Nicholson (:bnicholson)]

http://hg.mozilla.org/releases/mozilla-beta/rev/72825e7f22f7