Closed
Bug 775057
Opened 13 years ago
Closed 13 years ago
time_end in report is an hour out
Categories
(Testing Graveyard :: Mozmill, defect)
Testing Graveyard
Mozmill
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: davehunt, Unassigned)
References
Details
(Keywords: regression, Whiteboard: [mozmill-2.0+])
Attachments
(1 file, 1 obsolete file)
It appears that the time_end is an hour earlier than it should be.. Running a single test I have a report with time_start of 2012-07-18T13:24:32Z and time_end of 2012-07-18T12:24:46Z
Looking at the code, endtime is using utcnow [1], whereas starttime using the local timezone [2]. I can come up with a pull request, but should we standardise on UTC or local timezone?
[1] https://github.com/mozautomation/mozmill/blob/master/mozmill/mozmill/__init__.py#L69
[2] https://github.com/mozautomation/mozmill/blob/master/mozmill/mozmill/__init__.py#L60
|
Reporter | |
Comment 1•13 years ago
|
||
Pointer to Github pull-request
|
|
Reporter | |
Comment 2•13 years ago
|
||
Comment on attachment 643336 [details]
Pointer to Github pull request: https://github.com/mozautomation/mozmill/pull/67
Pull request submitted using datetime.now(). Let me know if we should standardise on datetime.utcnow() instead.
Attachment #643336 -
Flags: review?(jhammel)
|
||
Comment 3•13 years ago
|
||
Regression from bug 585106. Formerly we used utcnow() so we should keep this behavior.
Blocks: 585106
Keywords: regression
|
|
||
Updated•13 years ago
|
Attachment #643336 -
Flags: review?(jhammel) → review-
|
|
Reporter | |
Comment 4•13 years ago
|
||
Pointer to Github pull-request
|
|
Reporter | |
Updated•13 years ago
|
Attachment #643368 -
Attachment is obsolete: true
|
|
Reporter | |
Comment 5•13 years ago
|
||
Comment on attachment 643336 [details]
Pointer to Github pull request: https://github.com/mozautomation/mozmill/pull/67
Switched to use datetime.utcnow()
Attachment #643336 -
Flags: review- → review?(jhammel)
|
||
Comment 6•13 years ago
|
||
Comment on attachment 643336 [details]
Pointer to Github pull request: https://github.com/mozautomation/mozmill/pull/67
looks good
Attachment #643336 -
Flags: review?(jhammel) → review+
|
|
Reporter | |
Comment 7•13 years ago
|
||
I only have read-only access to the repo. Can someone push this for me? Thanks! :)
|
|
Reporter | |
Updated•13 years ago
|
Whiteboard: [mozmill-2.0?] → [mozmill-2.0+]
Pushed. We need to get you access too.
https://github.com/mozautomation/mozmill/commit/a33b6e46b17c1295197dddd44939cc089169f464
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
|
Assignee | |
Updated•9 years ago
|
Product: Testing → Testing Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•