775100 - Remove 'xxx' logging in HistoryTab

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Awesomescreen, defect)

Description

[Mark Finkle (:mfinkle) (use needinfo?)]

We have this in two places:
  Log.i(LOGTAG, "xxx vis:

It needs to be removed from Fx16 and Fx17

http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/awesomebar/HistoryTab.java#188
http://mxr.mozilla.org/mozilla-central/source/mobile/android/base/awesomebar/HistoryTab.java#192

Comment 1

[Mark Finkle (:mfinkle) (use needinfo?)]

Attachment: patch

Comment 2

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/29070de9dbfc

Comment 3

[Mark Finkle (:mfinkle) (use needinfo?)]

Comment on attachment 643373 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): unneeded logging
User impact if declined: none
Testing completed (on m-c, etc.): landed on inbound
Risk to taking this patch (and alternatives if risky): No risk at all. Totally zero. Trust me.
String or UUID changes made by this patch: none

Comment 4

[Alex Keybl [:akeybl]]

(In reply to Mark Finkle (:mfinkle) from comment #3)
> Risk to taking this patch (and alternatives if risky): No risk at all.
> Totally zero. Trust me.

I'd really like to see some QA around this before uplifting...

Comment 5

[Alex Keybl [:akeybl]]

Comment on attachment 643373 [details] [diff] [review]
patch

Just kidding :P

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/29070de9dbfc

Comment 7

[Mark Finkle (:mfinkle) (use needinfo?)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/75c9b7bc4eb3