775174 - Add invalidation timeline to reftest analyzer

Status: NEW

(Core :: Layout, defect)

Description

[Matt Woodrow (:mattwoodrow)]

Attachment: Add invalidation timeline to reftest analyzer

Currently reftest logs only show the final state of test, and not the intermediate states caused by invalidation.

This changes the test harness to dump the intermediate data URL's and also adds support to reftest analyzer to view them.

It adds a panel to the right of the images with the full reftest debug log, where the DoDrawWindow entries are clickable and update the image to the data recorded at that point.

The javascript probably isn't great, suggestions welcome.

Comment 1

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 643447 [details] [diff] [review]
Add invalidation timeline to reftest analyzer

r=dbaron

(Though I wonder whether it's better to pass gCurrentCanvas from every caller or just make DoDrawWindow operate on gCurrentCanvas and not pass an argument there at all.)

(I didn't look at the reftest-analyzer changes closely, but I don't feel like I need to.)

Comment 2

[Matt Woodrow (:mattwoodrow)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6718d4c7b6c1

Comment 3

[Ed Morley [:emorley]]

Backed out for Android XUL R3 failures in animateMotion-rotate-*.svg (exact failing tests varied each time):
https://tbpl.mozilla.org/php/getParsedLog.php?id=13933020&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=13929098&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=13929220&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=13931258&tree=Mozilla-Inbound
https://tbpl.mozilla.org/php/getParsedLog.php?id=13931311&tree=Mozilla-Inbound
etc

https://hg.mozilla.org/integration/mozilla-inbound/rev/f90f53a4d6b5

Comment 4

[Ed Morley [:emorley]]

(In reply to Ed Morley [:edmorley] from comment #3)
> Backed out for Android XUL R3 failures 

Actually, this failed on XUL and Native, native R3 is just hidden for the time being due to being badly behaved (bug 777436).

Comment 5

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.