Open Bug 775174 Opened 10 years ago Updated 1 month ago

Add invalidation timeline to reftest analyzer

Categories

(Core :: Layout, defect)

x86
macOS
defect
Not set
normal

Tracking

()

People

(Reporter: mattwoodrow, Unassigned)

Details

Attachments

(1 file)

Currently reftest logs only show the final state of test, and not the intermediate states caused by invalidation.

This changes the test harness to dump the intermediate data URL's and also adds support to reftest analyzer to view them.

It adds a panel to the right of the images with the full reftest debug log, where the DoDrawWindow entries are clickable and update the image to the data recorded at that point.

The javascript probably isn't great, suggestions welcome.
Attachment #643447 - Flags: review?(dbaron)
Comment on attachment 643447 [details] [diff] [review]
Add invalidation timeline to reftest analyzer

r=dbaron

(Though I wonder whether it's better to pass gCurrentCanvas from every caller or just make DoDrawWindow operate on gCurrentCanvas and not pass an argument there at all.)

(I didn't look at the reftest-analyzer changes closely, but I don't feel like I need to.)
Attachment #643447 - Flags: review?(dbaron) → review+
(In reply to Ed Morley [:edmorley] from comment #3)
> Backed out for Android XUL R3 failures 

Actually, this failed on XUL and Native, native R3 is just hidden for the time being due to being badly behaved (bug 777436).

The bug assignee didn't login in Bugzilla in the last 7 months, so the assignee is being reset.

Assignee: matt.woodrow → nobody
You need to log in before you can comment on or make changes to this bug.