775250 - symlink buildbot master Makefile into its own buildbot-configs directory

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[[e-mail] (:bhearsum)]

Currently, the Makefile that each Buildbot master has (eg, /builds/buildbot/build1/Makefile) is a static copy that never gets updated after the master is initially set-up. It gets copied in from /builds/buildbot/buildbot-configs/Makefile.master.

As part of master set-up we should symlink that to buildbot-configs/Makefile.master rather than leaving it as a static old copy forever.

Rail even volunteered to fix this!

Comment 1

[Rail Aliiev [:rail]]

Attachment: fabric action to fix existing ones

Comment 2

[Rail Aliiev [:rail]]

Attachment: Makefile.setup: use ln -s

Comment 3

[Rail Aliiev [:rail]]

Comment on attachment 643556 [details] [diff] [review]
Makefile.setup: use ln -s

http://hg.mozilla.org/build/buildbot-configs/rev/5127bdaa5af3

Comment 4

[Rail Aliiev [:rail]]

Comment on attachment 643555 [details] [diff] [review]
fabric action to fix existing ones

http://hg.mozilla.org/build/tools/rev/00a21e19f87d

Comment 5

[Rail Aliiev [:rail]]

I ran the following to fix existing links:

for role in build scheduler tests try; do
  python manage_masters.py -f production-masters.json -R $role -j8 fix_makefile_symlink
done