775278 - Some EGL extension checks are missing

Status: RESOLVED INCOMPLETE

(Core :: Graphics, defect)

Description

[Kelsey Gilbert [:jgilbert]]

Some paths don't check the proper EGL extensions before using them.

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Add missing extension checks

More extension checks.

Comment 2

[Benoit Girard (:BenWa)]

Why do some ext check get their own helper and not others? It's seems very arbitrary.

Comment 3

[Kelsey Gilbert [:jgilbert]]

We should really only use helpers when using IsExtensionSupported is onerous or tricky, as with EGL_KHR_image support (provided by either EGL_KHR_image or EGL_KHR_image_base) and EGL_KHR_image_pixmap (either EGL_KHR_image or EGL_KHR_image_pixmap).

Comment 4

[Vladimir Vukicevic [:vlad] [:vladv] (needinfo me, slow to respond)]

Also EGLLibrary used to not have the same extension checking machinery, and just had a few bits with explicit helper functions.  Could go either way, really -- you could always flag EGL_KHR_image as present if the required component extensions are present whether it's actually reported or not in the string, too.

Comment 5

[Kelsey Gilbert [:jgilbert]]

(In reply to Vladimir Vukicevic [:vlad] [:vladv] from comment #4)
> Also EGLLibrary used to not have the same extension checking machinery, and
> just had a few bits with explicit helper functions.  Could go either way,
> really -- you could always flag EGL_KHR_image as present if the required
> component extensions are present whether it's actually reported or not in
> the string, too.

This is also possible, though a little tricky. Technically if it supports EGL_KHR_image but not EGL_KHR_image_base, it's nearly identical, save for the PRESERVE EGLImage creation option.

Comment 6

[Kelsey Gilbert [:jgilbert]]

Attachment: 0001-More-checks-for-EGLImage-extensions.patch

I necromanced this.