775288 - [bedrock] l10n blocks cannot be updated once on production

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Pascal Chevrel:pascalc]

If you update text of an l10n block in the svn repo of the localizer, it works locally, it works on dev-allizom but it doesn't work on production, the file remains set to the first version of the translation.

This happened twice, I had to file IT bugs to ask them to restart Apache (bug 775084, bug 774814), apparently, there is some caching in Django (or maybe jinja templates) that is causing that.

Here is what Jake Maul from IT diagnosed:

"These are fixed. I don't know what was wrong, but I restarted Apache on all of the prod nodes and now that block is gone. I suspect (but can not confirm) that Django's caching layer may have had old/bad data in it. www-dev gets restarted regularly, so it wouldn't be quite so affected by this kind of thing."

.lang files are not affected, only l10n blocks, making the feature largely broken.

Comment 1

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/a759b55cc1311398b76994a1136122e31a8f42b8
Turn off template cache. Fix bug 775288.

Comment 2

[[github robot]]

Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/258ab841c8c660d1c32bd611ca2ba6f0d6977fe9
Bug 775288 - Force auto_reload instead of disabling caching

Comment 3

[Anthony Ricaud (:rik)]

Committed r108110 to test if our other approach works.

Comment 4

[Anthony Ricaud (:rik)]

Test is successful! Reverted in r108116.

So this is fixed without performance drawbacks. Thanks pmac and jlongster for the research.

Comment 5

[Ben (:bensternthal)]

Is this in production? If so let's set as verified.

Comment 6

[Anthony Ricaud (:rik)]

Yes, this in production. Sorry for not updating.