Closed Bug 775316 Opened 13 years ago Closed 12 years ago

Upgrade Jingo - The way we call jingo is deprecated.

Categories

(support.mozilla.org :: Code Quality, task, P3)

Tracking

(Not tracked)

RESOLVED FIXED
2013Q1

People

(Reporter: mythmon, Assigned: rrosario)

References

Details

(Whiteboard: u=dev c=general p=1 s=2013.5)

This should be pretty easy to fix, because in theory when Jingo is present, it hooks into django.shortcuts.render() and calls itself instead of the Django templater. /home/mcooper/src/kitsune/vendor/src/jingo/jingo/__init__.py:74: DeprecationWarning: jingo.render() has been deprecated. Use django.shortcuts.render(). 'django.shortcuts.render().', DeprecationWarning)
Whiteboard: u=dev c= p=
I tried to switch to the jingo TemplateLoader once and ran into an issue with our emails that are django templates. We need a way for the template loader to know that emails are django templates and the rest are jinja2 templates. I think it requires changing the jingo template loader (or subclassing and modifying it in sumo) to handle this.
Target Milestone: --- → 2013Q1
Summary: The way we call jingo is deprecated. → Upgrade Jingo - The way we call jingo is deprecated.
When we do this, we can ditch lib/safe_django_forms.py and use jingo.monkey. That involves: 1. deleting that file 2. updating sumo/monkeypatch.py to use: import jingo.monkey jingo.monkey.patch() instead of safe_django_forms 3. possibly some other things--i forget
Depends on: 839157
If we fix bug 839157, then my issue in Comment 1 disappears.
Oh, that's funny. Also, I wrote a comment in this bug I have no recollection writing. Nor do I have a clue what I'm talking about. Monkey wat?
moving this to one spring after bug 839157
Priority: -- → P3
Whiteboard: u=dev c= p= → u=dev c=general p= s=2013.5
bug 839157 is in this sprint, so moving this one to the next one.
Whiteboard: u=dev c=general p= s=2013.5 → u=dev c=general p= s=2013.6
grabbing since we are unblocked
Assignee: nobody → rrosario
In a pull request: https://github.com/mozilla/kitsune/pull/1196 It was about 1 pt. Moving to current sprint.
Whiteboard: u=dev c=general p= s=2013.6 → u=dev c=general p=1 s=2013.5
You need to log in before you can comment on or make changes to this bug.