Upgrade Jingo - The way we call jingo is deprecated.

RESOLVED FIXED in 2013Q1

Status

P3
minor
RESOLVED FIXED
6 years ago
6 years ago

People

(Reporter: mythmon, Assigned: rrosario)

Tracking

unspecified
2013Q1
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: u=dev c=general p=1 s=2013.5)

(Reporter)

Description

6 years ago
This should be pretty easy to fix, because in theory when Jingo is present, it hooks into django.shortcuts.render() and calls itself instead of the Django templater.

/home/mcooper/src/kitsune/vendor/src/jingo/jingo/__init__.py:74: DeprecationWarning: jingo.render() has been deprecated.  Use django.shortcuts.render().
  'django.shortcuts.render().', DeprecationWarning)
(Reporter)

Updated

6 years ago
Whiteboard: u=dev c= p=
(Assignee)

Comment 1

6 years ago
I tried to switch to the jingo TemplateLoader once and ran into an issue with our emails that are django templates. We need a way for the template loader to know that emails are django templates and the rest are jinja2 templates. I think it requires changing the jingo template loader (or subclassing and modifying it in sumo) to handle this.
(Assignee)

Updated

6 years ago
Target Milestone: --- → 2013Q1
(Assignee)

Updated

6 years ago
Summary: The way we call jingo is deprecated. → Upgrade Jingo - The way we call jingo is deprecated.
When we do this, we can ditch lib/safe_django_forms.py and use jingo.monkey. That involves:

1. deleting that file

2. updating sumo/monkeypatch.py to use:

      import jingo.monkey
      jingo.monkey.patch()

   instead of safe_django_forms

3. possibly some other things--i forget
(Assignee)

Updated

6 years ago
Depends on: 839157
(Assignee)

Comment 3

6 years ago
If we fix bug 839157, then my issue in Comment 1 disappears.
Oh, that's funny.

Also, I wrote a comment in this bug I have no recollection writing. Nor do I have a clue what I'm talking about. Monkey wat?
moving this to one spring after bug 839157
Priority: -- → P3
Whiteboard: u=dev c= p= → u=dev c=general p= s=2013.5
(Assignee)

Comment 6

6 years ago
bug 839157 is in this sprint, so moving this one to the next one.
Whiteboard: u=dev c=general p= s=2013.5 → u=dev c=general p= s=2013.6
(Assignee)

Comment 7

6 years ago
grabbing since we are unblocked
Assignee: nobody → rrosario
(Assignee)

Comment 8

6 years ago
In a pull request:
https://github.com/mozilla/kitsune/pull/1196

It was about 1 pt. Moving to current sprint.
Whiteboard: u=dev c=general p= s=2013.6 → u=dev c=general p=1 s=2013.5
You need to log in before you can comment on or make changes to this bug.