775316 - Upgrade Jingo - The way we call jingo is deprecated.

Status: RESOLVED FIXED

(support.mozilla.org :: Code Quality, task, P3)

Description

[Michael Cooper [:mythmon]]

This should be pretty easy to fix, because in theory when Jingo is present, it hooks into django.shortcuts.render() and calls itself instead of the Django templater.

/home/mcooper/src/kitsune/vendor/src/jingo/jingo/__init__.py:74: DeprecationWarning: jingo.render() has been deprecated.  Use django.shortcuts.render().
  'django.shortcuts.render().', DeprecationWarning)

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

I tried to switch to the jingo TemplateLoader once and ran into an issue with our emails that are django templates. We need a way for the template loader to know that emails are django templates and the rest are jinja2 templates. I think it requires changing the jingo template loader (or subclassing and modifying it in sumo) to handle this.

Comment 2

[Will Kahn-Greene [:willkg] ET needinfo? me]

When we do this, we can ditch lib/safe_django_forms.py and use jingo.monkey. That involves:

1. deleting that file

2. updating sumo/monkeypatch.py to use:

      import jingo.monkey
      jingo.monkey.patch()

   instead of safe_django_forms

3. possibly some other things--i forget

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

If we fix bug 839157, then my issue in Comment 1 disappears.

Comment 4

[Will Kahn-Greene [:willkg] ET needinfo? me]

Oh, that's funny.

Also, I wrote a comment in this bug I have no recollection writing. Nor do I have a clue what I'm talking about. Monkey wat?

Comment 5

[Kadir Topal [:atopal]]

moving this to one spring after bug 839157

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

bug 839157 is in this sprint, so moving this one to the next one.

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

grabbing since we are unblocked

Comment 8

[Ricky Rosario [:rrosario, :r1cky]]

In a pull request:
https://github.com/mozilla/kitsune/pull/1196

It was about 1 pt. Moving to current sprint.

Comment 9

[Ricky Rosario [:rrosario, :r1cky]]

Landed on master:
https://github.com/mozilla/kitsune/commit/5166f833f71e49d2f9c5d5d50b440f5190ba93f2

Comment 10

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod. I had to commit these followup fixes:
https://github.com/mozilla/kitsune/commit/9ebf604ae74f36d88bd3c2f36eecadcbc384da08
https://github.com/mozilla/kitsune/commit/ac8df91774435b6f5fa8eac9bf981e56f71ba345
https://github.com/mozilla/kitsune/commit/1baee61c8c769e5905185ca67bc688b2a3e5438b