775332 - a11y: Make sender names bold in message listing on SUMO

Status: RESOLVED FIXED

(support.mozilla.org :: General, defect)

Description

[David Weir (satdav)]

Attachment: Message System screen

https://support.mozilla.org/messages

Can i suggest we make the names bold on the Message system 

guidelines are on http://www.w3.org/TR/WCAG/

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

Bram, thoughts on this?

Comment 2

[David Weir (satdav)]

whats the ux status on this bug

Comment 3

[Bram Pitoyo [:bram]]

(In reply to David W from comment #0)
> Can i suggest we make the names bold on the Message system 

I don’t see why not because it’s one CSS class that takes no time to change.

But please keep in mind that, when making contributor-related interface changes like this, most of our contributors need no accessibility help, and since they’re a heavy user, they might be opposed to the changes. Just something to keep in mind.

The CSS class to change is:

article.message-list span.user a {
    color: #282828;
    font-weight: bold;
}

Comment 4

[Tobias (:Tobbi) Markus]

I already did the changes here:
https://github.com/mozilla/kitsune/pull/727

Comment 5

[Will Kahn-Greene [:willkg] ET needinfo? me]

Landed in master in https://github.com/mozilla/kitsune/commit/71a535ff3710d0699e604f8b3ea778d071df75fe

Comment 6

[James Socol [:jsocol, :james]]

Out of curiosity, what guideline was specifically cited in comment 0?

If we are going to make changes on the basis of a11y and cite the guidelines, let's please cite them accurately and precisely. In this case, the relevant guideline, as far as I can tell, is 1.4: Distinguishability[1] which deals with text/background contrast and doesn't mention font weight at all except in cases of "large scale" text (in which case it says that larger/bolder text doesn't need as high a contrast ratio).

[1] http://www.w3.org/TR/WCAG/#visual-audio-contrast

If this is just because it looks better, that's one thing, but if we're going to call on WCAG to justify changes, let's please actually read what the WCAG recommendations are and follow them.

Comment 7

[Will Kahn-Greene [:willkg] ET needinfo? me]

I'm totally +1 with James.

Also, this was pushed to production just now.

Tobbi: Can you verify that it's fixed/working in production and if so, mark this bug as FIXED?

Comment 8

[Tobias (:Tobbi) Markus]

This is fixed on prod now!

Comment 9

[Bram Pitoyo [:bram]]

(In reply to David W from comment #0)

I agree with both James and Will. Please make sure that a proper reason is made for UX changes. If it helps, cite from the specific part of the document rather than link to it. That way, we can see why the change was proposed, and what to do about it.