Closed Bug 775406 Opened 12 years ago Closed 12 years ago

please add email signup back to the What's New page

Categories

(www.mozilla.org :: General, defect)

Product:
www.mozilla.org
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jslater, Assigned: rik)

References

(
URL
)

Details

(Whiteboard: u=user c=email p=2)

Attachments

(1 file)

What's New - Firefox 14 - revised
679.11 KB, image/png
Details 
Hey Mike. It looks like in the push to update the What's New page for Fx14 we lost the email newsletter sign-up at the bottom. It's quite possible that something got lost in the communication, but it was never our intent to remove it as it's an important engagement channel.

We'd like to add it back as soon as possible, as our email signup rate has (not surprisingly) dropped pretty significantly. Let me know what the best way to get that going is.

Thanks much,
John


P.S. Winston, can you confirm which localized pages this should be on? I want to make sure we're covered everywhere.
Assignee: malexis → steven
Target Milestone: --- → 3.6
Assignee: steven → craigcook.bugz
Required:

* Add form back

Nice to have:

* see if we can move up the Google Play button up the page (John to have Lee create mock up)
Thanks Chris. Lee, please post that new mockup here when you have it...at that point we can evaluate whether it can be taken care of as part of this bug or whether it warrants a new one.
Attaching mockup here. 
Note, the "Get Firefox for Android and put the power..." copy has been removed.
Can someone verify that this was removed on purpose because the form strings were in en-US only? If the strings were in en-US only, we could wrap a conditional around it to make it for en-US only OR get those strings translated asap.
(In reply to Lee Tom from comment #3)
> Created attachment 643901 [details]
> What's New - Firefox 14 - revised
> 
> Attaching mockup here. 
> Note, the "Get Firefox for Android and put the power..." copy has been
> removed.

Looks good to me, thanks for the really quick turnaround. 

Craig, can we work this change in too? Let us know if you think it needs a separate bug or not.

Lee, might as well post the PSD here just in case.
PSD is here:
http://cl.ly/0s0M3G2D1I1b
Hey Craig,

When the newsletter signup form is reimplemented, can we make sure it's the same signup form that was on the updated whatsnew page for 13.0? (The form should have a drop down menu for country and language.)

I'd like to make sure we avoid the problem we had last time when the 13.0 what's new page first launched: https://bugzilla.mozilla.org/show_bug.cgi?id=764676

Thanks!
For the newsletter, it's because the view is not setting the email_form variable. So the templates can't render the form.

The page() method in apps/mozorg/util.py has all the details to get that set up.
Jess: Bedrock is not yet ready to handle forms for other countries. When I fix this, I'll see if I can do something quickly to make it happen but we're not gonna block on it.
I think I mean that the email signup form that's implemented on this page should be one that includes the drop down menus for "country" and "language" - that way whenever/however it shows (whether on en-US or an l10n page) - people are able to choose this information. I think it's more of a form design that's on a page, rather than the webpage infrastructure itself.
Taking this as it involves back-end more than front-end.
Assignee: craigcook.bugz → anthony
Thanks, Anthony.  Any ETA on when this might be back on the What's New page?
(In reply to Winston Bowden from comment #12)
> Thanks, Anthony.  Any ETA on when this might be back on the What's New page?

Seconding that question...this is definitely high priority.
I'll work on this as soon as our performance issues are solved (bug 760570). Without that, every time someone tries to subscribe to our newsletter, it can take up to 40 seconds to answer which is unacceptable.
Can we at least go ahead and move the button up above the video as indicated in the PSD from comment #6? 

I'd like to fix both at the same time, but if there's going to be a delay on the newsletter we should try to get the button moved up sooner...we need to do everything we can to increase mobile downloads.

Thanks-
Performance issues resolved due to the issue that Rik discovered. Nice work!

Rik: We didn't get this bug discussed on today's 2-week sprint planning. Since this is a regression, can we get on this during this sprint?
So I worked on the email issue and it's currently in the review cycle. https://github.com/mozilla/bedrock/pull/288

John: For the layout changes, should we also move up the download button on pages without videos? See http://www.mozilla.org/ru/firefox/whatsnew/ http://www.mozilla.org/nl/firefox/whatsnew/ for the two other ways this page looks. I think yes.
If you can mimic the way Lee set it up in comment #6, then yes please. Thanks!
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/f839568ae6f2761876670d03e6968e947c3e9b5a
Bug 775406 - Bring the download button higher

Also removes one copy line.

https://github.com/mozilla/bedrock/commit/94a3a14d4596640f11dc53f50e9d519b061174db
Merge pull request #293 from Rik/android-button-775406

Bug 775406 - Bring the download button higher
The button fixage has been pushed to production.
Great news, thanks Anthony. Do you have an estimate on when the email signup will be fixed?
Pull request updated. I might push this as soon as it's reviewed later today.
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/ede8656d3e742c24ce1272c9c5b6886fdb10383d
Bug 775406 - Enable newsletter signup on pages with default email block

- Move the newsletter subscription logic in a middleware
- Change the templates to use the variables available on request
- A few tests
- Some import, PEP8 cleanups
- Removed unused NoVarySessionMiddleware

https://github.com/mozilla/bedrock/commit/fcdc18b7c657c8c3084091f493cdbbbb740a658d
Bug 775406 - Validate the newsletter id

newsletter becomes a FormField
Please let me know when the newsletter is on a dev-site to test. I'm happy to make sure that the form is working as it should in Exact Target. Thanks!
Whiteboard: u=user c=email p=2
Thanks Anthony.  I tested: http://www.allizom.org/en-US/firefox/whatsnew/

and it works okay for any EN locale - however it is missing the language and country fields.

Is the reason why we can't implement the same signup form that was on the FF13 whatsnew page because of the new bedrock infrastructure for this page?


If it is not possible to implement the FF13 whatsnew page's newsletter signup form for FF14 whatsnew, it is okay to push this signup form live to any EN locale - however it should not be pushed to any non-EN locale. (l10n versions of the newsletter must have the language and country fields, otherwise they will be signed up for the English newsletter from what they will assume is a localized newsletter since the signup form is localized.)

Is it possible to prepare for FF15's whatsnew page to host the correct localized versions of the email signup form?  Without the localized versions of the signup form on the whatsnew page, our weekly l10n newsletter signups have decreased by 50%
Yes, it is (sadly) because of the transition to Bedrock.

I'll change the code so that this newsletter form is displayed also for en-GB and en-ZA.

To add the language and country fields to this signup form, please open a new bug so that we can track it and prioritize it.
Sounds good. Thanks, Anthony. 

Let me know when it's pushed live so I can double check that all is good for those forms on en-US, en-GB, and en-ZA.

I'll get crackin' on the other bug.
Pushed to production.
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
w00t!
Excellent! It looks great and works!  Thanks, Anthony & team.
(In reply to Anthony Ricaud (:rik) from comment #27)

> To add the language and country fields to this signup form, please open a
> new bug so that we can track it and prioritize it.

Just filed: Bug 780701
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: