If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Main menu breaks Alt-← navigation on mozilla.org when a menu is open

RESOLVED FIXED

Status

www.mozilla.org
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Clochix, Assigned: Kafji)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [good first bug][mentor=anthony@ricaud.me])

(Reporter)

Description

5 years ago
Go to a page on mozilla.org with a top menu, like http://www.mozilla.org/en-US/firefox/all.html
Hover the top menu with your mouse pointer. The menu opens.
Now try to go back to previous page with the keyboard shortcut Alt-←. The page intercepts the key and navigate inside the menu.

Tabzilla.initSubmenu in tabzilla.js should test id event.altKey is false.
(Reporter)

Updated

5 years ago
Summary: Tabzilla.js break Alt-← navigation broken on mozilla.org when a menu is open → Tabzilla.js break Alt-← navigation on mozilla.org when a menu is open
(In reply to Clochix from comment #0)
> Go to a page on mozilla.org with a top menu, like
> http://www.mozilla.org/en-US/firefox/all.html
> Hover the top menu with your mouse pointer. The menu opens.
> Now try to go back to previous page with the keyboard shortcut Alt-←. The
> page intercepts the key and navigate inside the menu.
> 
> Tabzilla.initSubmenu in tabzilla.js should test id event.altKey is false.

I tried this OS X 10.7 and wasn't able to reproduce this
(Reporter)

Comment 2

5 years ago
I've reproduced this in both Firefox and Chromium, on GNU/Linux and MS/Windows.
AFAIK, OS X uses Cmd instead of Alt to navigate into history, so maybe MacOS is not affected by this problem.
Confirmed this is happening on OS X too. We need to check if a modifier key is used. The code lives in js/nav-main.js.

I can mentor anyone who wants to fix this.
Whiteboard: [good first bug][mentor=anthony@ricaud.me]
Also, this is not a problem with Tabzilla.

Updated

5 years ago
Assignee: nobody → kafji.exe
Summary: Tabzilla.js break Alt-← navigation on mozilla.org when a menu is open → Main menu breaks Alt-← navigation on mozilla.org when a menu is open

Comment 5

5 years ago
Is this bug taken?
(Assignee)

Comment 6

5 years ago
(In reply to Victor Mejia from comment #5)
> Is this bug taken?

Yes, I'm working on this.
But I've had trouble to run Bedrock in my local and still trying to resolve it.

Comment 7

5 years ago
Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/d60ddf09fcab2824803774dfdc21ef366ab78d26
Main menu breaks Alt-← navigation

With the menu open, don't catch key events if a modifier key is pressed

fix bug 775475

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
I backported this to the PHP website too in r108175. Pushed to stage with r108176 and to production with r108177.

I'll push the Bedrock side to production later today.
Pushed to production on Bedrock too.
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.