Closed Bug 775557 Opened 12 years ago Closed 12 years ago

[bedrock] a typo in a replacemejnt variable on a .lang file can crash the entire website for the locale

Categories

(www.mozilla.org :: General, defect)

defect
Not set
normal

Tracking

(Not tracked)

VERIFIED FIXED

People

(Reporter: pascalc, Assigned: rik)

References

(Blocks 1 open bug)

Details

(Whiteboard: [l10n][sb-sprint-1] u=user c=L10N p=2)

See this example:
;Portions of this content are ©1998–%(current_year)s by individual mozilla.org contributors. Content available under a <a href="%(url)s">Creative Commons license</a>.
Portions of this content are ©1998–%(current_years by individual mozilla.org contributors. Content available under a <a href="%(url)s">Creative Commons license</a>.

Note that a parentesis in for the year variable is missing, a typo. All the pages that use main.lang now crash, the whole site disappears in an error 500 for the locale because that string is in our footer.

Bedrock should ignore strings malformed and just fallback to English, not black out the entire locale.
See Also: → 775264
Whiteboard: [l10n] → [l10n][sb-sprint-1]
Assignee: nobody → anthony
Whiteboard: [l10n][sb-sprint-1] → [l10n][sb-sprint-1] u=user c=L10N p=2
Commit pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/e55dabf0cfd7ca06f30085037b3471791ae0decf
Detect string formatting issues

- Fallback to original string
- Mail managers

fix bug 775557
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
Double checking if this is in prod. If so ... verify.
Yes, this is in prod. Sorry for forgetting to update.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.