The default bug view has changed. See this FAQ.

[AccessFu] Add dump tree and accessible states methods to logger

RESOLVED FIXED in mozilla17

Status

()

Core
Disability Access APIs
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: eeejay, Assigned: eeejay)

Tracking

Trunk
mozilla17
ARM
Android
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

5 years ago
Created attachment 643935 [details] [diff] [review]
Added dump tree Logger method, and states to string function.
Attachment #643935 - Flags: review?(dbolter)
Comment on attachment 643935 [details] [diff] [review]
Added dump tree Logger method, and states to string function.

Review of attachment 643935 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/src/jsat/Utils.jsm
@@ +168,5 @@
> +  },
> +
> +  statesToString: function statesToString(aAccessible) {
> +    let [state, extState] = Utils.getStates(aAccessible);
> +    let statesArray = [];

I'd probably call it stringArray, or strings, but not stingRay because that would be silly.
Attachment #643935 - Flags: review?(dbolter) → review+
(Assignee)

Comment 3

5 years ago
http://hg.mozilla.org/integration/mozilla-inbound/rev/69a69e2a873d
Assignee: nobody → eitan
Target Milestone: --- → mozilla17
(Assignee)

Comment 4

5 years ago
(In reply to David Bolter [:davidb] from comment #2)
> Comment on attachment 643935 [details] [diff] [review]
> Added dump tree Logger method, and states to string function.
> 
> Review of attachment 643935 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: accessible/src/jsat/Utils.jsm
> @@ +168,5 @@
> > +  },
> > +
> > +  statesToString: function statesToString(aAccessible) {
> > +    let [state, extState] = Utils.getStates(aAccessible);
> > +    let statesArray = [];
> 
> I'd probably call it stringArray, or strings, but not stingRay because that
> would be silly.

LOL. Changed.
https://hg.mozilla.org/mozilla-central/rev/69a69e2a873d
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.