775715 - Video controls incorrectly using videoHeight

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

We have the following code in videocontrols.xml:

  // If we have metadata, check if this is a <video> without
  // video data, or a video with no audio track.
  if (this.video.readyState >= this.video.HAVE_METADATA) {
      if (this.video instanceof HTMLVideoElement &&
          (this.video.videoWidth == 0 || this.videoHeight == 0))
          this.isAudioOnly = true;

That second last line should be:

          (this.video.videoWidth == 0 || this.video.videoHeight == 0))

i.e. s/this.videoHeight/this.video.videoHeight/

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Patch

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 643991 [details] [diff] [review]
Patch

Review of attachment 643991 [details] [diff] [review]:
-----------------------------------------------------------------

D'oh! Thanks for catching this. I ran a search on MXR for any other instances of this.videoHeight (or this.videoWidth) and didn't see any other ones.

Comment 3

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/11b96d52903f

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/11b96d52903f