Warn of mousemove, and possibly mouseover and mouseout events

RESOLVED FIXED in 2013-01-03

Status

addons.mozilla.org Graveyard
Add-on Validation
RESOLVED FIXED
5 years ago
2 years ago

People

(Reporter: kmag, Assigned: basta)

Tracking

unspecified
2013-01-03

Details

(Whiteboard: [ReviewTeam])

mousemove, mouseover, and mouseout events are dispatched with high frequency, and can cause major performance problems, especially when their handlers are expensive. When used judiciously for specific elements, they're relatively performant, but I've come across two add-ons using them with delegation on entire documents, which is not.
(Assignee)

Comment 1

5 years ago
Can you provide a heuristic for detecting abuse of these?
A substring match would be fine. You're not likely to find those strings anywhere but an event listener. Add to the above list mouseenter and mouseleave, which are worse than mouseover and mouseout.
We want to look for mousemove, mouseover, and mouseout in add-on code.
Assignee: nobody → mattbasta
Target Milestone: --- → 2013-01-03
(Assignee)

Comment 4

5 years ago
Merged:

https://github.com/mozilla/amo-validator/commit/c3a3c9c5265cce5220898185282ab238737d1b86
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.