Closed Bug 775716 Opened 13 years ago Closed 12 years ago

Warn of mousemove, and possibly mouseover and mouseout events

Categories

(addons.mozilla.org Graveyard :: Add-on Validation, defect)

Product:
addons.mozilla.org Graveyard
Component:
Add-on Validation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
2013-01-03

People

(Reporter: kmag, Assigned: basta)

Details

(Whiteboard: [ReviewTeam])

mousemove, mouseover, and mouseout events are dispatched with high frequency, and can cause major performance problems, especially when their handlers are expensive. When used judiciously for specific elements, they're relatively performant, but I've come across two add-ons using them with delegation on entire documents, which is not.
Can you provide a heuristic for detecting abuse of these?
A substring match would be fine. You're not likely to find those strings anywhere but an event listener. Add to the above list mouseenter and mouseleave, which are worse than mouseover and mouseout.
We want to look for mousemove, mouseover, and mouseout in add-on code.
Assignee: nobody → mattbasta
Target Milestone: --- → 2013-01-03
Merged: https://github.com/mozilla/amo-validator/commit/c3a3c9c5265cce5220898185282ab238737d1b86
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Product: addons.mozilla.org → addons.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.