775719 - "entries.nextFile is not a function" in TelemetryPing.js during startup

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect)

Description

[Jesse Ruderman]

Steps to reproduce using a Tinderbox debug build:

1. mkdir ~/pxd/
2. firefox -profile ~/pxd/
3. Use about:config to set
      user_pref("toolkit.telemetry.enabled", true);
4. firefox -profile ~/pxd/

During startup:

************************************************************
* Call to xpconnect wrapped JSObject produced this error:  *
[Exception... "'[JavaScript Error: "entries.nextFile is not a function" {file: "resource:///components/TelemetryPing.js" line: 744}]' when calling method: [nsIObserver::observe]"  nsresult: "0x80570021 (NS_ERROR_XPC_JAVASCRIPT_ERROR_WITH_DETAILS)"  location: "native frame :: <unknown filename> :: <TOP_LEVEL> :: line 0"  data: yes]
************************************************************

I'm guessing this is a regression from bug 763524.

Comment 1

[Nathan Froyd [:froydnj]]

Attachment: patch

Almost checked this in under r=obvious, but you never know...

Comment 2

[Nathan Froyd [:froydnj]]

Attachment: patch

Sigh, let's not reintroduce the opposite problem...

Comment 3

[Nathan Froyd [:froydnj]]

http://hg.mozilla.org/integration/mozilla-inbound/rev/360686937a0a

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/360686937a0a

Comment 5

[Jesse Ruderman]

This patch changed the first argument to loadHistograms:
  old:  entries.nextFile 
  new:  entries.nextFile()

Is that a problem?

Comment 6

[Josh Matthews [:jdm]]

I think you mean the reverse, and no, that was the point of this bug. nextFile is an attribute, not a function.

Comment 7

[Nathan Froyd [:froydnj]]

(In reply to Josh Matthews [:jdm] from comment #6)
> I think you mean the reverse, and no, that was the point of this bug.
> nextFile is an attribute, not a function.

Yes.  This is an unfortunate wart in the nsIDirectoryEnumerator API, IMHO.  A TranslateWeirdXPCOMAPIsToSaneJavascript.jsm would be appreciated...