775723 - Native handles shrink when dragged to the right/bottom of the content area

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: Text Selection, defect)

Description

[:Margaret Leibovic]

This is something Android is doing with the ImageViews that we're using. It would be ideal if there was a way to let them overflow gecko_layout so that they just get cut off (this currently works when dragging to the left/top of the content area).

Comment 1

[:Margaret Leibovic]

Attachment: patch

This fixes the issue by adding negative right/bottom margin to the handles.

Comment 2

[:Margaret Leibovic]

https://hg.mozilla.org/integration/mozilla-inbound/rev/8ac4a4902afe

Comment 3

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/8ac4a4902afe

Comment 4

[:Margaret Leibovic]

Comment on attachment 644045 [details] [diff] [review]
patch

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 774938 (native text selection handles)
User impact if declined: handles shrink when dragged to the edge of the screen
Testing completed (on m-c, etc.): landed on m-c 7/20
Risk to taking this patch (and alternatives if risky): low-risk style change
String or UUID changes made by this patch: n/a

Comment 5

[Lukas Blakk [:lsblakk] use ?needinfo]

Comment on attachment 644045 [details] [diff] [review]
patch

approved for beta/aurora as part of the dep bugs for native handles for text selection.

Comment 6

[:Margaret Leibovic]

https://hg.mozilla.org/releases/mozilla-aurora/rev/19f189f814a5
https://hg.mozilla.org/releases/mozilla-beta/rev/8301f1195f22