Closed
Bug 775723
Opened 13 years ago
Closed 13 years ago
Native handles shrink when dragged to the right/bottom of the content area
Categories
(Firefox for Android Graveyard :: Text Selection, defect)
Tracking
(firefox15 verified, firefox16 verified, firefox17 verified)
VERIFIED
FIXED
Firefox 17
People
(Reporter: Margaret, Assigned: Margaret)
References
Details
Attachments
(1 file)
3.30 KB,
patch
|
mfinkle
:
review+
lsblakk
:
approval-mozilla-aurora+
lsblakk
:
approval-mozilla-beta+
|
Details | Diff | Splinter Review |
This is something Android is doing with the ImageViews that we're using. It would be ideal if there was a way to let them overflow gecko_layout so that they just get cut off (this currently works when dragging to the left/top of the content area).
Assignee | ||
Comment 1•13 years ago
|
||
This fixes the issue by adding negative right/bottom margin to the handles.
Assignee: nobody → margaret.leibovic
Attachment #644045 -
Flags: review?(mark.finkle)
Updated•13 years ago
|
Attachment #644045 -
Flags: review?(mark.finkle) → review+
Assignee | ||
Comment 2•13 years ago
|
||
Target Milestone: --- → Firefox 17
Comment 3•13 years ago
|
||
Status: NEW → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Assignee | ||
Comment 4•13 years ago
|
||
Comment on attachment 644045 [details] [diff] [review]
patch
[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 774938 (native text selection handles)
User impact if declined: handles shrink when dragged to the edge of the screen
Testing completed (on m-c, etc.): landed on m-c 7/20
Risk to taking this patch (and alternatives if risky): low-risk style change
String or UUID changes made by this patch: n/a
Attachment #644045 -
Flags: approval-mozilla-beta?
Attachment #644045 -
Flags: approval-mozilla-aurora?
Comment 5•13 years ago
|
||
Comment on attachment 644045 [details] [diff] [review]
patch
approved for beta/aurora as part of the dep bugs for native handles for text selection.
Attachment #644045 -
Flags: approval-mozilla-beta?
Attachment #644045 -
Flags: approval-mozilla-beta+
Attachment #644045 -
Flags: approval-mozilla-aurora?
Attachment #644045 -
Flags: approval-mozilla-aurora+
Assignee | ||
Comment 6•13 years ago
|
||
https://hg.mozilla.org/releases/mozilla-aurora/rev/19f189f814a5
https://hg.mozilla.org/releases/mozilla-beta/rev/8301f1195f22
status-firefox15:
--- → fixed
status-firefox16:
--- → fixed
Updated•13 years ago
|
status-firefox17:
--- → verified
Updated•13 years ago
|
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•