PromptListAdapter extends ArrayAdapter but reimplements its existing functionality

RESOLVED FIXED in Firefox 17

Status

()

Firefox for Android
General
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: mcomella, Assigned: mcomella)

Tracking

Trunk
Firefox 17
ARM
Android
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/PromptService.java#470

Specifically, mList is used instead of the existing ArrayAdapter methods. Thus, several methods are overridden which do not need to be (getCount, getItem, getItemId, perhaps more).

Also, getView should have the @Override annotation.
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
Created attachment 644028 [details] [diff] [review]
Patch

I think I hit all of the reimplemented functionality.
Attachment #644028 - Flags: review?(wjohnston)
Comment on attachment 644028 [details] [diff] [review]
Patch

Review of attachment 644028 [details] [diff] [review]:
-----------------------------------------------------------------

Nice cleanup! Thanks!
Attachment #644028 - Flags: review?(wjohnston) → review+
Keywords: checkin-needed
https://hg.mozilla.org/integration/mozilla-inbound/rev/b154dfeb6905
Flags: in-testsuite-
Keywords: checkin-needed

Comment 4

5 years ago
https://hg.mozilla.org/mozilla-central/rev/b154dfeb6905
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
You need to log in before you can comment on or make changes to this bug.