Closed
Bug 775740
Opened 14 years ago
Closed 13 years ago
PromptListAdapter extends ArrayAdapter but reimplements its existing functionality
Categories
(Firefox for Android Graveyard :: General, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 17
People
(Reporter: mcomella, Assigned: mcomella)
Details
Attachments
(1 file)
|
2.28 KB,
patch
|
wesj
:
review+
|
Details | Diff | Splinter Review |
https://mxr.mozilla.org/mozilla-central/source/mobile/android/base/PromptService.java#470
Specifically, mList is used instead of the existing ArrayAdapter methods. Thus, several methods are overridden which do not need to be (getCount, getItem, getItemId, perhaps more).
Also, getView should have the @Override annotation.
|
Assignee | |
Updated•14 years ago
|
Assignee: nobody → michael.l.comella
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 1•14 years ago
|
||
I think I hit all of the reimplemented functionality.
Attachment #644028 -
Flags: review?(wjohnston)
|
||
Comment 2•13 years ago
|
||
Comment on attachment 644028 [details] [diff] [review]
Patch
Review of attachment 644028 [details] [diff] [review]:
-----------------------------------------------------------------
Nice cleanup! Thanks!
Attachment #644028 -
Flags: review?(wjohnston) → review+
|
|
Assignee | |
Updated•13 years ago
|
Keywords: checkin-needed
|
||
Comment 3•13 years ago
|
||
Flags: in-testsuite-
Keywords: checkin-needed
|
||
Comment 4•13 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
|
||
Updated•5 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•