77582 - CVS Commit Access for David Bradley

Status: RESOLVED FIXED

(mozilla.org :: Repository Account Requests, task)

Description

[Phil Schwartau]

David is a new-hire in the XPCOM component.

I am cc'ing jband as a "voucher" for Kenton, per the instructions
at http://www.mozilla.org/hacking/getting-cvs-write-access.html.
As indicated there, jband should add a comment to this bug: 

2. "When you have a voucher, ask that person to add a comment to the bug 
   saying s/he's vouching."

jband will also know whether super-review approval is necessary or not:

3. "Determine whether or not you need super-reviewer approval..."
4. "If not, note in the bug why super-reviewer approval is not needed."

Comment 1

[John Bandhauer]

Yes, I'm a voucher for David. jst and beard both told me they'd also vouch for 
him.

I'm thinking that Phil may have been a little confused about the super-review 
issue. This is not something that we could confer upon David here and now. I 
assume that it was an instruction that David is supposed to follow in his future 
checkins.

Comment 2

[Blake Ross]

Three superreviewers are needed (technically one non-netscaper; cc'ing shaver) 
and a voucher.

Comment 3

[Patrick C. Beard]

I vouch for David.

Comment 4

[David Bradley]

I have faxed the form, hopefully it got there ok. e-mail me at 
[e-mail] if it didn't.

Comment 5

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

Yeah, you need three super-reviewers to approve the account creation, based on
patches and work submitted to bugzilla and the tree.

I'm happy to be a non-netscape.com super-reviewer (assuming I still count as
one), if someone can point me at bugs and patches that David has worked on.

Comment 6

[Marcia Knous [:marcia]]

form received.

Comment 7

[Johnny Stenback (:jst)]

Put me up as a voucher for David too...

Comment 8

[Brendan Eich [:brendan]]

I can sr= David's access, and it sounds like shaver will too, once someone cites
some bugs with patches that were committed.

/be

Comment 9

[David Bradley]

Bugs/patches

Bug -> http://bugzilla.mozilla.org/show_bug.cgi?id=83591
Patch -> http://bugzilla.mozilla.org/showattachment.cgi?attach_id=38272

Bug -> http://bugzilla.mozilla.org/show_bug.cgi?id=24965
Patch -> http://bugzilla.mozilla.org/showattachment.cgi?attach_id=36366

Bug -> http://bugzilla.mozilla.org/show_bug.cgi?id=33193
Patch -> http://bugzilla.mozilla.org/showattachment.cgi?attach_id=37377

The following is a combo of my patch and jband's addition to clean things up
properly.

Bug -> http://bugzilla.mozilla.org/show_bug.cgi?id=87389
Patch->http://bugzilla.mozilla.org/showattachment.cgi?attach_id=42508

Comment 10

[Mike Shaver (:shaver -- probably not reading bugmail closely)]

sr=shaver.

Comment 11

[Marcia Knous [:marcia]]

sr=shaver and sr=brendan. not sure if jst is giving his sr or not. if so, we can 
activate David's account.

Comment 12

[Johnny Stenback (:jst)]

yes, my above comment was meant to say that I will indeed sr this request, I
should've stated that in my comment...

Comment 13

[Marcia Knous [:marcia]]

Account activated.