Last Comment Bug 775867 - Make it more convenient to break on protocol errors
: Make it more convenient to break on protocol errors
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: IPC (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-20 00:52 PDT by Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
Modified: 2012-07-24 03:02 PDT (History)
1 user (show)
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Implement ProtocolErrorBreakpoint() for easier debugging of IPC errors (4.55 KB, patch)
2012-07-20 00:55 PDT, Chris Jones [:cjones] inactive; ni?/f?/r? if you need me
bent.mozilla: review+
Details | Diff | Splinter Review

Description Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-07-20 00:52:57 PDT
We've discussed this several times in the past, and when looking at bug 767480 I sorely needed this so wrote it.

The upcoming patch adds the interface mozilla::ipc::ProtocolErrorBreakpoint(), which prints to stdout in DEBUG builds and may be breakable in opt builds.  All deserialization etc errors call this function.
Comment 1 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-07-20 00:55:09 PDT
Created attachment 644213 [details] [diff] [review]
Implement ProtocolErrorBreakpoint() for easier debugging of IPC errors
Comment 2 Ben Turner (not reading bugmail, use the needinfo flag!) 2012-07-22 10:01:15 PDT
Comment on attachment 644213 [details] [diff] [review]
Implement ProtocolErrorBreakpoint() for easier debugging of IPC errors

Review of attachment 644213 [details] [diff] [review]:
-----------------------------------------------------------------

Sweet!
Comment 3 Chris Jones [:cjones] inactive; ni?/f?/r? if you need me 2012-07-23 11:08:24 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/78a198fc21d5
Comment 4 Ed Morley [:emorley] 2012-07-24 03:02:13 PDT
https://hg.mozilla.org/mozilla-central/rev/78a198fc21d5

Note You need to log in before you can comment on or make changes to this bug.