Last Comment Bug 775914 - mozInlineSpellChecker copies OperationID enum from editor
: mozInlineSpellChecker copies OperationID enum from editor
Status: RESOLVED FIXED
:
Product: Core
Classification: Components
Component: Editor (show other bugs)
: Trunk
: All All
: -- normal (vote)
: mozilla17
Assigned To: :Aryeh Gregor (working until September 2)
:
Mentors:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2012-07-20 04:39 PDT by :Aryeh Gregor (working until September 2)
Modified: 2012-07-22 12:44 PDT (History)
1 user (show)
ayg: in‑testsuite-
See Also:
Crash Signature:
(edit)
QA Whiteboard:
Iteration: ---
Points: ---
Has Regression Range: ---
Has STR: ---


Attachments
Patch (4.90 KB, patch)
2012-07-20 05:02 PDT, :Aryeh Gregor (working until September 2)
ehsan: review+
Details | Diff | Splinter Review

Description :Aryeh Gregor (working until September 2) 2012-07-20 04:39:58 PDT
I discovered this in mozInlineSpellChecker.h when looking into bug 674927:

  // TODO: these should be defined somewhere so that they don't have to be copied
  // from editor!
  enum OperationID
  {
    kOpIgnore = -1,
    kOpNone = 0,
    kOpUndo,
    kOpRedo,
    kOpInsertNode,
    kOpCreateNode,
    kOpDeleteNode,
    kOpSplitNode,
    kOpJoinNode,
    kOpDeleteSelection,

    kOpInsertBreak    = 1000,
    kOpInsertText     = 1001,
    kOpInsertIMEText  = 1002,
    kOpDeleteText     = 1003,

    kOpMakeList            = 3001,
    kOpIndent              = 3002,
    kOpOutdent             = 3003,
    kOpAlign               = 3004,
    kOpMakeBasicBlock      = 3005,
    kOpRemoveList          = 3006,
    kOpMakeDefListItem     = 3007,
    kOpInsertElement       = 3008,
    kOpInsertQuotation     = 3009,
    kOpSetTextProperty     = 3010,
    kOpRemoveTextProperty  = 3011,
    kOpHTMLPaste           = 3012,
    kOpLoadHTML            = 3013,
    kOpResetTextProperties = 3014,
    kOpSetAbsolutePosition = 3015,
    kOpRemoveAbsolutePosition = 3016,
    kOpDecreaseZIndex      = 3017,
    kOpIncreaseZIndex      = 3018
  };

Bug 751547 changed around some of the id's, so this might actually lead to bugs.
Comment 1 :Aryeh Gregor (working until September 2) 2012-07-20 05:02:14 PDT
Created attachment 644263 [details] [diff] [review]
Patch
Comment 2 :Aryeh Gregor (working until September 2) 2012-07-20 05:20:08 PDT
Try: https://tbpl.mozilla.org/?tree=Try&rev=a8c0cd74adc0
Comment 3 :Ehsan Akhgari 2012-07-20 06:49:26 PDT
Comment on attachment 644263 [details] [diff] [review]
Patch

Review of attachment 644263 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!
Comment 4 :Aryeh Gregor (working until September 2) 2012-07-22 07:52:19 PDT
https://hg.mozilla.org/integration/mozilla-inbound/rev/187fab385cb4
Comment 5 Ryan VanderMeulen [:RyanVM] 2012-07-22 12:44:16 PDT
https://hg.mozilla.org/mozilla-central/rev/187fab385cb4

Note You need to log in before you can comment on or make changes to this bug.