775939 - Cannot open include file: 'audio_coding_module_typedefs.h': No such file or directory

Status: RESOLVED FIXED

(Core :: WebRTC, defect)

Description

[Sergey Zolotarev]

User Agent: Mozilla/5.0 (Windows NT 6.1; rv:14.0) Gecko/20100101 Firefox/14.0.1
Build ID: 20120713134347

Steps to reproduce:

Tried to build latest mozilla-central (rev 99767 on branch "default") using MSVC 10.0


Actual results:

Compilation stopped at this:

../../../../../../../media/webrtc/trunk/src/video_engine/..\modules/utility/interface/file_recorder.h(14) : fatal error C1083: Cannot open include file: 'audio_coding_module_typedefs.h': No such file or directory

Comment 1

[Sergey Zolotarev]

Another error:

z:\programming\thirdpartysources\mozilla-central\media\webrtc\trunk\src\voice_engine\main\source\channel.h(15) : fatal error C1083: Cannot open include file: 'audio_conference_mixer_defines.h': No such file or directory

Comment 2

[ABE Hiroki (:hATrayflood)]

Attachment: fix: change topsrcdir, srcdir and VPATH to absolute path

Comment 3

[ABE Hiroki (:hATrayflood)]

this errors are caused by relative $(topsrcdir), $(srcdir) and $(VPATH) in generated Makefile.
To fix, change $(topsrcdir), $(srcdir) and $(VPATH) to absolute path.

Comment 4

[(not currently active) Ted Mielczarek]

Comment on attachment 696621 [details] [diff] [review]
fix: change topsrcdir, srcdir and VPATH to absolute path

Review of attachment 696621 [details] [diff] [review]:
-----------------------------------------------------------------

::: media/webrtc/trunk/tools/gyp/pylib/gyp/generator/mozmake.py
@@ +370,5 @@
>      else:
>        # Maybe nothing?
>        return False
> +    if self.flavor == 'win' and os.environ.get('.PYMAKE', os.environ.get('_PYMAKE')) != '1':
> +      top = '/' + self.topsrcdir[0:1] + self.topsrcdir[2:]

This is going to break people who build with pymake but don't use client.mk. I think we should just fix bug 828317 so we can only support pymake-style windows paths on windows.

Comment 5

[ABE Hiroki (:hATrayflood)]

Attachment: fix v2: always absolute path

Comment 6

[(not currently active) Ted Mielczarek]

Comment on attachment 754119 [details] [diff] [review]
fix v2: always absolute path

Review of attachment 754119 [details] [diff] [review]:
-----------------------------------------------------------------

This seems fine now that we stopped supporting GNU make on Windows (bug 828317).

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/02d5396a69c5

Comment 8

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/02d5396a69c5