Company Identifier (UA String) field too narrow

VERIFIED FIXED

Status

CCK
CCK-General
VERIFIED FIXED
17 years ago
17 years ago

People

(Reporter: blee, Assigned: Shruti Vasudevan)

Tracking

Details

(Whiteboard: nscckb1 nscckrtm -Need to review patch,r=tao)

Attachments

(4 attachments)

(Reporter)

Description

17 years ago
(improvement suggestion from Onedisk feedback)

Company Identifier (UA String) field is limited 10 characters, and cuts off 
anything beyond that. A more accommodating size is desirable.
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 1

17 years ago
Created attachment 36492 [details] [diff] [review]
Patch file to make the size of the company identifier field upto 20 characters

Comment 2

17 years ago
The patch changes the string length from 10 to 20. How was this determined?

For a reference on user-agent strings see:
  http://www.mozilla.org/build/revised-user-agent-strings.html

In some of the examples, the vendor strings exceed 20 characters:
   Mozilla/5.001 (...) Gecko/25250101 MegaCorpBrowser/1.0 (MegaCorp, Inc.)
   Mozilla/9.876 (...) Gecko/25250101 Netscape/5.432b1 (C-MindSpring)

I think we should make the string as long as the UI allows.  If we put the
text field on a separate line, it should allow 40-50 or more characters.
(Assignee)

Comment 3

17 years ago
Created attachment 36596 [details] [diff] [review]
Patch file to accomodate long user agent strings
(Assignee)

Comment 4

17 years ago
Created attachment 36597 [details] [diff] [review]
Patch file to accomodate long user agent strings
(Assignee)

Comment 5

17 years ago
In order to preserve the appearance of the UI, I have made the user agent string 
to be a maximum of 60 characters. I can make it to be much longer than this, but 
then the UI may look cluttered.

Sorry, the above patch accidentally got submitted twice.

Comment 6

17 years ago
Needed for Beta.
Whiteboard: nscckb1

Updated

17 years ago
Whiteboard: nscckb1 → nscckb1 r=bobj
(Assignee)

Comment 8

17 years ago
Checked in patch. Marking this as fixed.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 9

17 years ago
Added info on this bug fix to the What's New section of the CCK PR1 Release Notes
(Assignee)

Comment 10

17 years ago
Reopening to determine the exact length of the user agent string.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 11

17 years ago
Reassigning bug to johng.
Assignee: shrutiv → johng
Status: REOPENED → NEW

Updated

17 years ago
Blocks: 89481

Comment 12

17 years ago
This bug blocks 89481, which is the doc bug regarding specification of UA string 
length

Updated

17 years ago
Whiteboard: nscckb1 r=bobj → nscckb1 r=bobj, nscckrtm

Comment 13

17 years ago
Removed "r=bobj" which was for the previous fix (6/4/2001).

This bug has been reopened to reevaluate the length limitations that may be
imposed by the limitation of the website tracking tools.

Summarizing my understanding from an email thread:
  (1) Some marketing database stores only 50 characters of the user-agent
      string which is useless because even non-customized Netscape or Mozilla
      user-agent strings will be truncated (and it will never store any of the
      customized component).  Further, no one currently uses the user-agent
      strings store in this database.
  (2) Log files store the entire user-agent string, but the reporting
      tool that parses the logs is broken and needs to be fixed.

JohnG, What is the status on this bug?
Whiteboard: nscckb1 r=bobj, nscckrtm → nscckb1 nscckrtm
(Assignee)

Comment 14

17 years ago
The total length of the user agent string should be 13 chars. This includes 3 
chars for "CK-" and 10 chars for the actual string the user enters.
Assignee: johng → shrutiv
(Assignee)

Comment 15

17 years ago
Created attachment 43033 [details] [diff] [review]
Patch file to limit the user agent string to 10 chars
(Assignee)

Updated

17 years ago
Status: NEW → ASSIGNED
Whiteboard: nscckb1 nscckrtm → nscckb1 nscckrtm -Need to review patch

Updated

17 years ago
Whiteboard: nscckb1 nscckrtm -Need to review patch → nscckb1 nscckrtm -Need to review patch,r=tao
(Assignee)

Comment 16

17 years ago
Marking fixed
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago17 years ago
Resolution: --- → FIXED
(Reporter)

Comment 17

17 years ago
Still not very clear what the length of ua string would be. 7/25 bld shows the 
reversion to the original text. Marking this Verified for now.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.