The default bug view has changed. See this FAQ.

double click on column headers should not to open selected history item in History window(Ctrl+H)

RESOLVED FIXED in seamonkey2.14

Status

SeaMonkey
Bookmarks & History
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: Alice0775 White, Assigned: neil@parkwaycc.co.uk)

Tracking

Trunk
seamonkey2.14

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Reporter)

Description

5 years ago
User agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:17.0) Gecko/17.0 Firefox/17.0 SeaMonkey/2.14a1
Build identifier: 20120720003018

In History window(Ctrl+H), if you have some line in the history selected
and double-click on a column headers, --the column sort order
changes twice (as expected), and the history represented by the current
row selection is opened.

Reproducible: Always

Steps to Reproduce:
1. Open History window(Ctrl+H)
2. Expand tree and select history item
3. Click twice quickly on a column header


Actual Results:  
 the selected history is "opened" 

Expected Results:  
 should not open

Comment 1

5 years ago
http://hg.mozilla.org/comm-central/annotate/89103361cbf2/suite/common/history/history.xul#l114

108   <tree id="historyTree"
109         class="placesTree plain"
110         context="placesContext"
111         flex="1" type="places"
112         enableColumnDrag="true"
113         onselect="historyOnSelect();"
114         onkeypress="if (event.keyCode == KeyEvent.DOM_VK_RETURN) PlacesUIUtils.openNodeWithEvent(gHistoryTree.selectedNode, event);"
115         ondblclick="if (event.button == 0) PlacesUIUtils.openNodeWithEvent(gHistoryTree.selectedNode, event);"
116         onclick="if (event.button == 1) PlacesUIUtils.openNodeWithEvent(gHistoryTree.selectedNode, event);">

Hmm. Looks like the click and double-click events bubble up.
Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Firefox/17.0 SeaMonkey/2.14a1 ID:20120720003018 CSet: ecf5155354d8

Happens not only on Alice's W32-on-W64 but also on this Linux64 build.
OS: Windows 7 → All
Hardware: x86_64 → All
(Assignee)

Comment 3

5 years ago
Created attachment 644450 [details] [diff] [review]
Proposed patch

Unless someone wants to rewrite the history window to share the places front end with bookmarks, as it has its own anti-column-doubleclicking code ;-)
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #644450 - Flags: review?(philip.chee)

Comment 4

5 years ago
Comment on attachment 644450 [details] [diff] [review]
Proposed patch

Looks good.
Attachment #644450 - Flags: review?(philip.chee) → review+
(Assignee)

Comment 5

5 years ago
Pushed comm-central changeset 07aee55a81ca.
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

5 years ago
Target Milestone: --- → seamonkey2.14
You need to log in before you can comment on or make changes to this bug.