Closed
Bug 776072
Opened 12 years ago
Closed 12 years ago
Hide browsertoolbar from geckoapp
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(Not tracked)
RESOLVED
FIXED
Firefox 17
People
(Reporter: wesj, Unassigned)
Details
Attachments
(1 file, 1 obsolete file)
|
4.71 KB,
patch
|
mfinkle
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Reporter | |
Updated•12 years ago
|
Attachment #644421 -
Attachment is patch: true
|
|
Reporter | |
Comment 1•12 years ago
|
||
I'm not entirely sure there aren't races here to worry about, but I can't see them. This seems fine on my phones/tablets. We could move the super call in BrowserToolbar.onCreate to be later if it helps. You know mfinkle?
Attachment #644421 -
Attachment is obsolete: true
Attachment #644424 -
Flags: review?(mark.finkle)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 644424 [details] [diff] [review] Patch v2 I don't know of any potential races here. Testing will show us if there are any. This is cleaner.
Attachment #644424 -
Flags: review?(mark.finkle) → review+
|
|
Reporter | |
Comment 3•12 years ago
|
||
http://hg.mozilla.org/integration/mozilla-inbound/rev/8b53a264ceb7
|
||
Comment 4•12 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8b53a264ceb7
Status: NEW → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 17
|
Assignee | |
Updated•3 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•